vlad-ivanov-name / xtensa2arm

0 stars 0 forks source link

Drop rustc-serialize dependency #1

Closed dtolnay closed 7 years ago

dtolnay commented 7 years ago

It has been deprecated: announcement.

Is there any functionality you would require from another library before this would be possible?

vlad-ivanov-name commented 7 years ago

Not sure if this issue was created automatically, but nonetheless, rustc-serialize is used by radare2 binding, that's why I'm using it too.

dtolnay commented 7 years ago

Thanks for the update! Do you know whether they are planning on moving away from it? Is there an issue on their end?

vlad-ivanov-name commented 7 years ago

whether they are planning on moving away from it

I don't really know — this binding is not that big piece of software, but here's their repo — issue can be opened there https://github.com/radare/r2pipe.rs

dtolnay commented 7 years ago

Cool I'll follow up there.

dtolnay commented 7 years ago

In https://github.com/radare/r2pipe.rs/issues/19 the r2pipe.rs author says they would welcome a PR to update to Serde. Would you be interested in taking care of that?

vlad-ivanov-name commented 7 years ago

I'm quite new to Rust. Also, I'm afraid I don't have enough time for that currently.

jrozner commented 7 years ago

Sorry to bump this but I just submitted a PR to fix this. Not sure if they plan to merge it or if this is still relevant, because it's closed, but just wanted to update you.