search

vlad17 / datasketches-rs

Rusty wrapper for Apache DataSketches
Apache License 2.0
11 stars 3 forks source link

Doesn't build on MacOS #3

Open timbray opened 5 months ago

timbray commented 5 months ago 
cargo build
 ... much elided ...
  = note: ld: library 'stdc++' not found
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

Apparently it's supposed to be libc++ not stdc++ these days but I'm not a Rustafarian and couldn't figure out how to make that work either.

vlad17 commented 5 months ago

Hey Tim, thanks for reporting this. Unfortunately, I don’t have a Mac and everything seems to be working fine on my old Ubuntu laptop.

googling around, adding this crate as a dependency locally might help? https://docs.rs/link-cplusplus/latest/link_cplusplus/

timbray commented 5 months ago

I’ll have a look, but I’m a Rust moron. I’m about to release v1.0 of topfew and I thought I should mention alternatives.

On Apr 20, 2024 at 9:12:57 PM, Vladimir Feinberg @.***> wrote:

Hey Tim, thanks for reporting this. Unfortunately, I don’t have a Mac and everything seems to be working fine on my old Ubuntu laptop.

googling around, adding this crate as a dependency locally might help? https://docs.rs/link-cplusplus/latest/link_cplusplus/

— Reply to this email directly, view it on GitHub https://github.com/vlad17/datasketches-rs/issues/3#issuecomment-2067884447, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEJE2MJRX5XF23KA3MSKDY6M4ETAVCNFSM6AAAAABGEURXY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXHA4DINBUG4 . You are receiving this because you authored the thread.Message ID: @.***>

vlad17 commented 4 months ago

@timbray , would you be able to try @ovr's fix?

ovr commented 4 months ago

@vlad17 FYI, as a part of changes in PR #4, I've added CI

https://github.com/cube-js/datasketches-rs/actions/runs/8970862322/job/24635298556

image

It builds successfully :)