vlad17 / mve

MVE: model-based value estimation
Apache License 2.0
10 stars 0 forks source link

consistent units #314

Closed vlad17 closed 6 years ago

vlad17 commented 6 years ago

currently, main_ddpg uses timesteps and main_cmpc uses episodes. This is problematic b/c it changes the meaning of --save_every and --render_every, flags shared between the two.

Currently, for main_ddpg, *_every means "every N samples (which is every timesteps_per_sample * N timesteps).

For main_cmpc *_every means every N episodes.

Both are not in a consistent, desirable state. It should be that:

  1. main_cmpc uses timesteps as well
  2. *_every refers to the number TIMESTEP between saves/renders/etc. Currently neither main_ddpg or main_cmpc do this.

Then the save_every default should be changed accordingly.j

vlad17 commented 6 years ago

dupe of #313