search

vlad2305m / Sound-Physics-Fabric

A Minecraft mod that provides realistic sound attenuation, reverberation, and absorption through blocks.
GNU General Public License v3.0
39 stars 6 forks source link

Jukeboxes unaffected by sound dampening #38

Closed SleepyTonia closed 2 years ago

SleepyTonia commented 2 years ago

I'm mostly putting this here as a feature proposal since jukeboxes are deliberately made louder than anything else, but I think it would be a great addition if they could sound a bit more… immersive and accurate I guess?

thedocruby commented 2 years ago

I noticed this is a problem for Note Blocks as well. @vlad2305m can you look into this? Outside my area of expertise.

vlad2305m commented 2 years ago

This is intentional by sonic so that your noteblock mess in the walls, alarm, whatever... doesn't stop working. A setting for ignored sounds, or a setting for skipping occlusion can solve this. @thedocruby https://github.com/vlad2305m/Sound-Physics-Fabric/blob/4a116d466ad86cb753966e7af32260f04a3f6bf9/src/main/java/com/sonicether/soundphysics/SoundPhysics.java#L207 Here is the statement. Perhaps just extract records to another if below and give them direct pass.

thedocruby commented 2 years ago

Here is the statement. Perhaps just extract records to another if below and give them direct pass.

@vlad2305m I tried completely removing lastSoundCategory == SoundCategory.RECORDS from the if statement and it appears to have no affect. I will continue to search for a solution, but I ask that you help as well.