vlad2305m / Sound-Physics-Fabric

A Minecraft mod that provides realistic sound attenuation, reverberation, and absorption through blocks.
GNU General Public License v3.0
39 stars 6 forks source link

Errors with my mod stack and incompatibility with Bobby mod #45

Closed giorov closed 2 years ago

giorov commented 2 years ago

When I have this mod and Bobby mod on at the same time, chunks fail to load properly.

Happens most severely online, on Wildercraft for example.

2021-12-19_12 35 32

In SP it's more difficult to reproduce.

2021-12-20_00 52 34

log from a session online and a session offline.

latest.log

Here are interesting errors/warnings I got in online portion of that logfile:

giorov commented 2 years ago
``` [00:43:07] [main/WARN]: Warnings were found! - Mod 'Sodium Extra' (sodium-extra) 0.3.7 recommends version 1.2.3 or later of reeses-sodium-options, which is missing! - You should install version 1.2.3 or later of reeses-sodium-options for the optimal experience. [00:43:08] [main/WARN]: Error loading class: grondag/canvas/terrain/region/input/InputRegion (java.lang.ClassNotFoundException: grondag/canvas/terrain/region/input/InputRegion) [00:43:08] [main/WARN]: Force-disabling mixin 'features.sky.MixinWorldRenderer' as rule 'mixin.features.sky' (added by mods [iris]) disables it and children [00:43:08] [main/WARN]: Error loading class: me/flashyreese/mods/reeses_sodium_options/client/gui/SodiumVideoOptionsScreen (java.lang.ClassNotFoundException: me/flashyreese/mods/reeses_sodium_options/client/gui/SodiumVideoOptionsScreen) [00:43:08] [main/INFO]: Trying to switch memory allocators to work around memory leaks present with Jemalloc 5.0.0 through 5.2.0 on Windows [00:43:10] [main/WARN]: Method overwrite conflict for method_9522 in sodium.mixins.json:features.render_layer.leaves.MixinLeavesBlock, previously written by eu.midnightdust.cullleaves.mixin.MixinLeavesBlock. Skipping method. [00:43:13] [main/WARN]: @Inject(@At("INVOKE")) Shift.BY=3 on fabric-lifecycle-events-v1.mixins.json:client.WorldChunkMixin::handler$zfa000$onLoadBlockEntity exceeds the maximum allowed value: 0. Increase the value of maxShiftBy to suppress this warning. [00:43:14] [Render thread/WARN]: Method overwrite conflict for method_22920 in sodium.mixins.json:features.buffer_builder.intrinsics.MixinBufferBuilder, previously written by net.coderbot.iris.mixin.vertices.block_rendering.MixinBufferBuilder_SeparateAo. Skipping method. [00:43:22] [Render thread/INFO]: [STDERR]: SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". [00:43:22] [Render thread/INFO]: [STDERR]: SLF4J: Defaulting to no-operation (NOP) logger implementation [00:43:22] [Render thread/INFO]: [STDERR]: SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. [00:43:23] [Render thread/INFO]: Using shaderpack: BSL_v8.1.02.2d.zip [00:43:25] [Render thread/WARN]: Method overwrite conflict for getNativeMemoryUsage in sodium.mixins.json:features.debug.MixinDebugHud, previously written by net.coderbot.iris.mixin.MixinDebugScreenOverlay. Skipping method. [00:43:25] [Worker-Main-21/ERROR]: No tile or block matches provided in file 'minecraft:optifine/ctm/chiseled_sandstone/chiseled_sandstone.properties' in pack 'Depixel(1).zip' [00:43:32] [Worker-Main-28/ERROR]: Using missing texture, unable to load minecraft:textures/continuity_reserved/811df03970e8599e7328ec61b9c5e45f.png : java.io.FileNotFoundException: minecraft:optifine/ctm/glass/59.png [00:43:32] [Worker-Main-21/WARN]: Texture minecraft:block/crimson_fungus_model with size 43x43 limits mip level from 4 to 0 [00:43:32] [Worker-Main-21/WARN]: minecraft:textures/atlas/blocks.png: dropping miplevel from 4 to 0, because of minimum power of two: 1 [00:43:32] [Render thread/WARN]: Method 'ctm' requires 47 tiles but 48 were provided in file 'minecraft:optifine/ctm/glass/glass_pane.properties' in pack 'Depixel(1).zip' [00:43:32] [Render thread/WARN]: Method 'ctm' requires 47 tiles but 48 were provided in file 'minecraft:optifine/ctm/glass/glass.properties' in pack 'Depixel(1).zip' [00:43:59] [Render thread/WARN]: Received packet for unknown team 06Gan_XodosA: team action: REMOVE, player action: null [00:43:59] [Render thread/INFO]: [CHAT] >> Gan_Xodos is here! [00:43:59] [Render thread/WARN]: Unknown custom packed identifier: venturechat:data [00:44:00] [Render thread/INFO]: Creating pipeline OVERWORLD [00:44:00] [Render thread/WARN]: [deferred1] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [deferred1] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [deferred1] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [deferred1] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [deferred1] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [deferred1] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [composite] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [composite] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [composite] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [composite] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [composite] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [composite] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [composite1] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [composite1] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [composite1] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [composite1] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [composite1] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [composite1] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [Triforce Patcher] gl_FragColor is not supported yet, please use gl_FragData! Assuming that the shaderpack author intended to use gl_FragData[0]... [00:44:00] [Render thread/WARN]: [gbuffers_basic] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_basic] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_basic] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_basic] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_basic] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_basic] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_basic_color] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_basic_color] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_basic_color] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_basic_color] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_basic_color] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_basic_color] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_textured] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_textured] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_textured] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_textured] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_textured] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_textured] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_textured_color] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_textured_color] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_textured_color] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_textured_color] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_textured_color] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_textured_color] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_sky_basic] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_sky_basic] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_sky_basic] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_sky_basic] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_sky_basic] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_sky_basic] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_sky_basic_color] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_sky_basic_color] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_sky_basic_color] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_sky_basic_color] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_sky_basic_color] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_sky_basic_color] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_clouds] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_clouds] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_clouds] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_clouds] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_clouds] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_clouds] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_terrain_solid] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_terrain_solid] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_terrain_solid] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_terrain_solid] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_terrain_solid] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_terrain_solid] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_terrain_cutout] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_terrain_cutout] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_terrain_cutout] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_terrain_cutout] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_terrain_cutout] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_terrain_cutout] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_terrain_cutout_mipped] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_terrain_cutout_mipped] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_terrain_cutout_mipped] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_terrain_cutout_mipped] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_terrain_cutout_mipped] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_terrain_cutout_mipped] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_entities_solid] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_entities_solid] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_entities_solid] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_entities_solid] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_entities_solid] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_entities_solid] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_entities_cutout] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_entities_cutout] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_entities_cutout] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_entities_cutout] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_entities_cutout] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_entities_cutout] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_hand_cutout] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_hand_cutout] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_hand_cutout] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_hand_cutout] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_hand_cutout] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_hand_cutout] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_hand_translucent] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_hand_translucent] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_hand_translucent] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_hand_translucent] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_hand_translucent] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_hand_translucent] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_lightning] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_lightning] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_lightning] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_lightning] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_lightning] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_lightning] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_leash] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_leash] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_leash] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_leash] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_leash] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_leash] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_particles] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_particles] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_particles] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_particles] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_particles] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_particles] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_weather] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_weather] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_weather] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_weather] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_weather] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_weather] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_entities_text] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_entities_text] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_entities_text] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_entities_text] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_entities_text] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_entities_text] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_entities_text_intensity] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_entities_text_intensity] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_entities_text_intensity] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_entities_text_intensity] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_entities_text_intensity] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_entities_text_intensity] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_block] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_block] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_block] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_block] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_block] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_block] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_lines] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_lines] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_lines] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_lines] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_lines] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_lines] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [gbuffers_translucent] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [gbuffers_translucent] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [gbuffers_translucent] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [gbuffers_translucent] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [gbuffers_translucent] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [gbuffers_translucent] Unsupported uniform: float isSwamp [00:44:00] [Render thread/INFO]: Stopping worker threads [00:44:00] [Render thread/INFO]: Started 8 worker threads [00:44:00] [Render thread/WARN]: [] Unsupported uniform: vec4 [repeats] [00:44:00] [Render thread/WARN]: [] Unsupported uniform: vec3 u_RegionOffset [00:44:00] [Render thread/WARN]: [] Unsupported uniform: vec4 [repeats] [00:44:00] [Render thread/WARN]: [] Unsupported uniform: vec3 u_RegionOffset [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [] Unsupported uniform: vec3 u_RegionOffset [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [] Unsupported uniform: vec3 u_RegionOffset [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isCold [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isDesert [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isMesa [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isMushroom [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isSavanna [00:44:00] [Render thread/WARN]: [] Unsupported uniform: float isSwamp [00:44:00] [Render thread/WARN]: [] Unsupported uniform: vec3 u_RegionOffset [00:44:01] [Render thread/INFO]: [STDOUT]: No Iris! [00:44:01] [Render thread/INFO]: [STDOUT]: No Iris! [00:44:01] [Render thread/INFO]: [STDOUT]: Reloading entity icon resources... [00:44:01] [Render thread/INFO]: [STDOUT]: Done! [00:44:01] [Render thread/INFO]: DurabilityViewer did not find Trinkets API [00:44:01] [Render thread/INFO]: DurabilityViewer did not find Tech Reborn ```

mixed repeats of the following errors:

``` [Render thread/FATAL]: Error executing task on Client java.lang.NullPointerException: Cannot assign field "zm" because the return value of "com.sonicether.soundphysics.performance.WorldChunkAccess.getNotAirLiquidStorage()" is null at net.minecraft.class_2818.handler$bif000$load(class_2818.java:2269) ~[client-intermediary.jar:?] at net.minecraft.class_2818.method_12224(class_2818.java:463) ~[client-intermediary.jar:?] at net.minecraft.class_631.method_16020(class_631.java:101) ~[client-intermediary.jar:?] at net.minecraft.class_634.method_38539(class_634.java:665) ~[client-intermediary.jar:?] at net.minecraft.class_634.method_11128(class_634.java:660) ~[client-intermediary.jar:?] at net.minecraft.class_2672.method_11528(class_2672.java:45) ~[client-intermediary.jar:?] at net.minecraft.class_2672.method_11054(class_2672.java:12) ~[client-intermediary.jar:?] at net.minecraft.class_2600.method_11072(class_2600.java:21) ~[client-intermediary.jar:?] at net.minecraft.class_1255.method_18859(class_1255.java:151) [client-intermediary.jar:?] at net.minecraft.class_4093.method_18859(class_4093.java:23) [client-intermediary.jar:?] at net.minecraft.class_1255.method_16075(class_1255.java:125) [client-intermediary.jar:?] at net.minecraft.class_1255.method_5383(class_1255.java:110) [client-intermediary.jar:?] at net.minecraft.class_310.method_1523(class_310.java:1080) [client-intermediary.jar:?] at net.minecraft.class_310.method_1514(class_310.java:733) [client-intermediary.jar:?] at net.minecraft.client.main.Main.main(Main.java:238) [client-intermediary.jar:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:608) [fabric-loader-0.12.12.jar:?] at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77) [fabric-loader-0.12.12.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.12.12.jar:?]` `[Render thread/FATAL]: Error executing task on Client java.lang.NullPointerException: Cannot assign field "xp" because the return value of "com.sonicether.soundphysics.performance.WorldChunkAccess.getNotAirLiquidStorage()" is null at net.minecraft.class_631.handler$big000$unload(class_631.java:1606) ~[client-intermediary.jar:?] at net.minecraft.class_631.method_2859(class_631.java) ~[client-intermediary.jar:?] at net.minecraft.class_634.method_11107(class_634.java:699) ~[client-intermediary.jar:?] at net.minecraft.class_2666.method_11486(class_2666.java:28) ~[client-intermediary.jar:?] at net.minecraft.class_2666.method_11054(class_2666.java:6) ~[client-intermediary.jar:?] at net.minecraft.class_2600.method_11072(class_2600.java:21) ~[client-intermediary.jar:?] at net.minecraft.class_1255.method_18859(class_1255.java:151) [client-intermediary.jar:?] at net.minecraft.class_4093.method_18859(class_4093.java:23) [client-intermediary.jar:?] at net.minecraft.class_1255.method_16075(class_1255.java:125) [client-intermediary.jar:?] at net.minecraft.class_1255.method_5383(class_1255.java:110) [client-intermediary.jar:?] at net.minecraft.class_310.method_1523(class_310.java:1080) [client-intermediary.jar:?] at net.minecraft.class_310.method_1514(class_310.java:733) [client-intermediary.jar:?] at net.minecraft.client.main.Main.main(Main.java:238) [client-intermediary.jar:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:608) [fabric-loader-0.12.12.jar:?] at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77) [fabric-loader-0.12.12.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.12.12.jar:?]` `[Render thread/FATAL]: Error executing task on Client java.lang.NullPointerException: Cannot assign field "xm" because the return value of "com.sonicether.soundphysics.performance.WorldChunkAccess.getNotAirLiquidStorage()" is null at net.minecraft.class_2818.handler$bif000$load(class_2818.java:2267) ~[client-intermediary.jar:?] at net.minecraft.class_2818.method_12224(class_2818.java:463) ~[client-intermediary.jar:?] at net.minecraft.class_631.method_16020(class_631.java:101) ~[client-intermediary.jar:?] at net.minecraft.class_634.method_38539(class_634.java:665) ~[client-intermediary.jar:?] at net.minecraft.class_634.method_11128(class_634.java:660) ~[client-intermediary.jar:?] at net.minecraft.class_2672.method_11528(class_2672.java:45) ~[client-intermediary.jar:?] at net.minecraft.class_2672.method_11054(class_2672.java:12) ~[client-intermediary.jar:?] at net.minecraft.class_2600.method_11072(class_2600.java:21) ~[client-intermediary.jar:?] at net.minecraft.class_1255.method_18859(class_1255.java:151) [client-intermediary.jar:?] at net.minecraft.class_4093.method_18859(class_4093.java:23) [client-intermediary.jar:?] at net.minecraft.class_1255.method_16075(class_1255.java:125) [client-intermediary.jar:?] at net.minecraft.class_1255.method_5383(class_1255.java:110) [client-intermediary.jar:?] at net.minecraft.class_310.method_1523(class_310.java:1080) [client-intermediary.jar:?] at net.minecraft.class_310.method_1514(class_310.java:733) [client-intermediary.jar:?] at net.minecraft.client.main.Main.main(Main.java:238) [client-intermediary.jar:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:608) [fabric-loader-0.12.12.jar:?] at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77) [fabric-loader-0.12.12.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.12.12.jar:?]` `[Render thread/FATAL]: Error executing task on Client java.lang.IllegalStateException: Tried to mark light data as ready for chunk [-433, 203] but it hasn't been loaded yet at me.jellysquid.mods.sodium.client.render.chunk.ChunkTracker.onLightDataAdded(ChunkTracker.java:92) ~[sodium-fabric-mc1.18.1-rc1-0.4.0-alpha5+build.813.jar:?] at me.jellysquid.mods.sodium.client.render.SodiumWorldRenderer.onChunkLightAdded(SodiumWorldRenderer.java:304) ~[sodium-fabric-mc1.18.1-rc1-0.4.0-alpha5+build.813.jar:?] at net.minecraft.class_638.handler$bfm000$postLightUpdate(class_638.java:3078) ~[client-intermediary.jar:?] at net.minecraft.class_638.method_39849(class_638.java:530) ~[client-intermediary.jar:?] at net.minecraft.class_634.method_38543(class_634.java:2198) ~[client-intermediary.jar:?] at net.minecraft.class_634.method_38545(class_634.java:2183) ~[client-intermediary.jar:?] at net.minecraft.class_634.redirect$bin000$starlightCallUpdateImmediately(class_634.java:7426) ~[client-intermediary.jar:?] at net.minecraft.class_634.method_11143(class_634.java:2183) ~[client-intermediary.jar:?] at net.minecraft.class_2676.method_11560(class_2676.java:37) ~[client-intermediary.jar:?] at net.minecraft.class_2676.method_11054(class_2676.java:11) ~[client-intermediary.jar:?] at net.minecraft.class_2600.method_11072(class_2600.java:21) ~[client-intermediary.jar:?] at net.minecraft.class_1255.method_18859(class_1255.java:151) [client-intermediary.jar:?] at net.minecraft.class_4093.method_18859(class_4093.java:23) [client-intermediary.jar:?] at net.minecraft.class_1255.method_16075(class_1255.java:125) [client-intermediary.jar:?] at net.minecraft.class_1255.method_5383(class_1255.java:110) [client-intermediary.jar:?] at net.minecraft.class_310.method_1523(class_310.java:1080) [client-intermediary.jar:?] at net.minecraft.class_310.method_1514(class_310.java:733) [client-intermediary.jar:?] at net.minecraft.client.main.Main.main(Main.java:238) [client-intermediary.jar:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:608) [fabric-loader-0.12.12.jar:?] at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77) [fabric-loader-0.12.12.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.12.12.jar:?] ```
giorov commented 2 years ago

If I disable Bobby but leave Sound Physics in I get this log (much, much cleaner)... latest.log

vlad2305m commented 2 years ago

Well. Bobby seems to make the game think that chunks, which are not loaded yet are "full" (means fully generated and loaded). Without Bobby, there are no SP errors.

Johni0702 commented 2 years ago

Well. Bobby seems to make the game think that chunks, which are not loaded yet are "full" (means fully generated and loaded).

No, no it doesn't. For one, there is no "generated" state on the client, it's either loaded or it isn't. But more importantly, it is loaded (as evident by the fact that the game can render the chunk, you can look at it, and if you can reach it, you could even interact with it). The reason Sound Physics dies is because it assumes that the only way a chunk could ever be loaded on the client is through a packet, which simply isn't true once you consider Bobby (cause that's the whole point).

To spell it out: Chunks loaded via packets use the first constructor, which passes a bunch of dummy values to the second one, and then call the method to fill in the chunk from a packet. Chunks loaded via Bobby use the second constructor, already passing fully valid values. So it doesn't need to load from a packet, and it can't cause there is none.

Without Bobby, there are no SP errors.

Without SP, there are no errors either. That doesn't mean anything. Especially not for compatibility issues.

(just for reference: https://github.com/Johni0702/bobby/issues/65)

vlad2305m commented 2 years ago

Thank you very much! Since it is that easy to fix, I will in an upcoming release. This block caching brings 6x performance improvement, so if you don't mind, you can use a previous version.

Konglomneshued commented 2 years ago

I have the same issue, invisible chunks that never load. When I check the minecraft log it has a bunch of errors like

[19:42:50] [Render thread/FATAL]: Error executing task on Client java.lang.NullPointerException: Cannot assign field "xm" because the return value of "com.sonicether.soundphysics.performance.WorldChunkAccess.getNotAirLiquidStorage()" is null

a lot of them.

thedocruby commented 2 years ago

I thought this was fixed by Vlad ages ago, but as i can confirm it has not been, I will fix it before the next release

thedocruby commented 2 years ago

@Johni0702 I'm struggling a bit with this. So from what I've gathered, the client always calls loadFromPacket() when loading chunks, except for when loading Bobby cached chunks, which come from the client's memory instead of from the server. Since these chunks are not Intitalized with Sound Physics, any time the game tries to load an adjacent chunk from a packet, the Sound Physics code causes it to fail and exit, which causes the chunk not to load properly in more ways than one.

So, the only thing I would need to do to fix it is to find a function that is called when loading both normal and cached chunks, and mixin there instead? Is there something I haven't considered? Is there an assumption that i made and shouldn't have? Is my logic flat out wrong? Or did i somehow manage to make sense of this issue?

Either way, i need some help figuring out how to fix this problem, if no other reason than a lack of confidence and experience. I'm outside my area of expertise here, and I'm struggling to make sense of it all. Any help is greatly appreciated. Thanks!

vlad2305m commented 2 years ago

I don't think there is such a function. You can try adding a variable "initialized" and copying the load-from-packet mixin over for the constructor. You can only mix in at constructor END and TAIL, so uninitiated stuff shouldn't be a problem.

Johni0702 commented 2 years ago

I don't understand everything you're doing in there but if we simply treat it as a black box, then yes, easiest way is to just move all that code into a separate private method and call that from both, the constructor (though only if chunkSections isn't null, cause if it is, then loadFromPacket will definitely be called later) and loadFromPacket.

vlad2305m commented 2 years ago

I don't understand everything you're doing in there but if we simply treat it as a black box, then yes, easiest way is to just move all that code into a separate private method and call that from both, the constructor (though only if chunkSections isn't null, cause if it is, then loadFromPacket will definitely be called later) and loadFromPacket.

After trying to understand how palleted storage works, I just treat it all as a black box. Doesn't decrease performance anyway.

thedocruby commented 2 years ago

You can try adding a variable "initialized" and copying the load-from-packet mixin over for the constructor.

So moving the mixin to the shared constructor should work, then? Is it really that simple? I will test this later today or tomorrow

vlad2305m commented 2 years ago

@thedocruby No. The whole point of not doing that in the first place because an empty constructor is called when you load from a packet. May work if we overwrite it IMMEDIATELY after or indeed do some checks.

thedocruby commented 2 years ago

Okay, well can you do this? I am struggling

vlad2305m commented 2 years ago

I made a draft, but have no way of checking it. Pleas fix the material settings so that I can commit it.

thedocruby commented 2 years ago

Okay, on it

thedocruby commented 2 years ago

Sorry, i keep hitting "close with comment"

@vlad2305m You're good to go with the drafts, be sure to pull before you push.

thedocruby commented 2 years ago

This has been fixed in the latest release