search

vlad2305m / Sound-Physics-Fabric

A Minecraft mod that provides realistic sound attenuation, reverberation, and absorption through blocks.
GNU General Public License v3.0
39 stars 6 forks source link

Reverb not working when Cheap shared airspace detection is enabled #52

Open ettiSurreal opened 2 years ago

ettiSurreal commented 2 years ago

Hello, i recently decided to give this mod a try and found that the reverb wasn't working. I have decided to try the sound physics remastered fork to find it working as intended, so i gave previous versions of this mod a try to find that the reverb was working fine in 0.5.1, in 0.5.2 it only seemed to affect distant sounds, and from 0.5.4 it doesn't seem to work at all. All other features of the mod seem to work fine in the latest version. I deleted the sound_physics.json5 every time i tried a different version.

thedocruby commented 2 years ago

hmm

thedocruby commented 2 years ago

this probably has to do with the profile changes. Try turning up the reverb gain in the settings

thedocruby commented 2 years ago

Jeez, keep hitting the damn comment and close button

thedocruby commented 2 years ago

You can also try applying the Super Reverb profile on top of the default profile, this should help

The default profile changed in 0.5.4, and since i can't think of any other way reverb was affected this is most likely the problem

thedocruby commented 2 years ago

OMG i need to stop this i'm so sorry

EDIT: i just installed the Refined GitHub extension which moves the close & comment button to the left. Shouldn't happen again. Sorry for the mess :/

ettiSurreal commented 2 years ago

Turning reverb gain all the way up didn't seem to do anything, and if by profile you mean preset, these don't seem to work either (unless i am doing something wrong), i have both Cloth API and Cloth Config installed. image

thedocruby commented 2 years ago

you have to backspace the "Choose" text, its a limitation of Cloth Config

thedocruby commented 2 years ago

if that doesnt work, let me know and i'll look into it further Thanks for submitting the issue!

ettiSurreal commented 2 years ago

Changing the preset did not seem to do anything, but good to know how to do it. I also restarted the game just to be sure.

ettiSurreal commented 2 years ago

IMPORTANT UPDATE: I found the source of the issue after reading the comments on CurseForge.

Enabling Cheap shared airspace detection seems to be the setting that completely gets rid of the reverb for me, so you might want to look into that. For example the piston demonstration doesn't at all work when the setting is on.

thedocruby commented 2 years ago

Oh wow, this is important info, thank you! I now know the cause of the issue, and it will be fixed in a future update. I had already planned to remove cheap shared airspace detection altogether since disabling that part of the code will break the reverb after i rewrite it (soon:tm:) but it looks like it already breaks it! Thanks for the info! :)

thedocruby commented 2 years ago

Also i was just breaking my back trying to figure out why i had to enable Quality preset to get the reverb to work, i thought it was just because Performance wasn't enough rays anymore for some reason. I guess this was the issue!