search

vladbat00 / bevy_egui

This crate provides an Egui integration for the Bevy game engine. 🇺🇦 Please support the Ukrainian army: https://savelife.in.ua/en/
MIT License
974 stars 252 forks source link

Update to bevy 0.15 #309

Closed Vrixyz closed 3 days ago

Vrixyz commented 2 months ago

Currently testing on bevy 0.15 rc3.

PPakalns commented 2 months ago

Currently testing on bevy commit 9386bd0

* cursor handling changed, I think we should initialize it for all windows if not present (currently not implemented), see discussion: https://github.com/mvlabat/bevy_egui/pull/309/files#r1780569354

Just brainstorming cursor handling. Maybe we could add for the window "EguiCursorIcon" component that bevy_egui sets.

We can provide a system that is added by default that correctly sets CursorIcon for the window from the egui EguiCursorIcon value.

But user could opt out: User can handle manually EguiCursorIcon, it could be useful in cases where user would like to read the EguiCursorIcon state, but would want to have custom logic (For example user is utilizing a lot of custom cursor icons. He needs information from egui about cursor type, but wants to manually set their own cursor icons from icon set that do not map to SystemCursorIcon enum.

In this case it would be nice if egui would not set CursorIcon component directly.

Probably this functionality could be added in a PR at later date.

khassar00 commented 1 month ago

bevy pushed version 0.15.0-rc.1

Vrixyz commented 1 month ago

bevy pushed version 0.15.0-rc.1

Friz64 commented 1 month ago

Also relevant: https://github.com/bevyengine/bevy/pull/16093. As a workaround we can always just enable the custom_cursor feature and probably no one will notice or care, but still, it's relevant.

Vrixyz commented 4 weeks ago

Also relevant: bevyengine/bevy#16093. As a workaround we can always just enable the custom_cursor feature and probably no one will notice or care, but still, it's relevant.

I implemented your suggestion by always enabling custom_cursor bevy feature, this is closest to previous behaviour, a future PR could easily build on that to add custom cursor support for bevy_egui, but I'll consider this out of scope for this "upgrade bevy" PR.

vladbat00 commented 3 days ago

@Vrixyz huge thanks, as always! I've just updated it to the actual 0.15 release and merged.