search

vladfolts / oberonjs

Oberon 07 compiler (written in JavaScript and translates to JavaScript)
MIT License
132 stars 22 forks source link

Adding support for Sublime 3 #54

Closed pjmlp closed 4 years ago

pjmlp commented 4 years ago

Many thanks for creating the plugin.

Since it failed to work with Sublime 3, I ended up fixing it on my side, and here are the changes I happened to do to make it work.

Also added the Mod extension, as it is the common one from Native Oberon files.

vladfolts commented 4 years ago

@pjmlp Will this still work for Sublime 2?

pjmlp commented 4 years ago

I cannot guarantee it, as I was forced to do these changes to make your plugin work on Sublime 3, given the breaking changes introduced in regards to _beginedit() and _endedit().

https://www.sublimetext.com/docs/3/porting_guide.html

As I don't have Sublime 2 around to test it, I am not sure if it will still work with it.

vladfolts commented 4 years ago

OK, I guess we don't have to care much about supporting version 2 since there are no many users anyway :) I'm merging this PR.