search

vladikoff / meteor-accounts-persona

Login service for Mozilla Persona accounts
MIT License
19 stars 6 forks source link

Remove included library #7

Closed badslug closed 11 years ago

badslug commented 11 years ago

Changed the Persona library include into documentation to include the script in templates until Meteor has the ability to specify remote javascript to include. This makes the smart package less critical to keep up to date with Mozilla changes.

I'm not really sure this should be the normal approach. So I don't know if you should actually accept this pull request. I'm sending it because it's better for my project but it may be best to leave it as a pull request so people can fork and pull it rather than make it the standard choice?

vladikoff commented 11 years ago

Hey! Thanks for the PR. You bring up a great point and this include issue has been bugging me since day one. The goal of this smart package was to show how Persona can be a better and easier choice of auth rather than the OAuth options. To make it even easier I decided not to proved 'include' setup instructions and just include the js file with the smart package.

Let me see if I can contact the meteor guys and maybe they can add an API to include external files, if that fails then I will probably switch to this method.

I'm also happy you are using this for your projects :)

badslug commented 11 years ago

I agree, getting the Meteor guys to make the API changes is definitely the best option. My few interactions with them in the past have been very pleasant - they are busy so it can take a while for changes to get into the codebase but they are definitely listening and care about issues encountered in the wild.

Thanks a ton for making the Persona package! It's so nice to use.