vladikoff / netflix-1080p-firefox

🍿 Force 1080p Netflix playback in Firefox
482 stars 42 forks source link

Make 5.1 audio work again #35

Closed okradonkey closed 4 years ago

okradonkey commented 4 years ago

Add rudimentary but functional Firefox options panel with checkbox to offer 5.1 audio if available. The options panel is accessible by clicking on Netflix 1080p in the about:addons list. (There is still no toolbar icon.)

Other than changing a few keywords to Firefox API, this PR is mostly adapted straight from the truedread extension. See the Commit comment for further details. I was able to test and confirm that 5.1 audio now works with this extension and Firefox 69 (only if enabled in options, of course). Could close Issue #22 if others can verify.

This opens the door for someone else to implement the Max Bitrate setting and add it to the options panel. I didn't understand truedread's code for that option so I omitted it.

okradonkey commented 4 years ago

Added one-liner .gitattributes file so Windows clients can sign the extension (see commit comment). Reason for change: https://github.com/vladikoff/netflix-1080p-firefox/issues/31#issuecomment-530619007