vladimarius / pyap

Python address detector and parser
MIT License
200 stars 60 forks source link

Parsing French Canadian Address with Occupancy #8

Open phicote opened 4 years ago

phicote commented 4 years ago

Hello Vlad! Congratulations for this amazing work, I really appreciate. However, I noticed that the parser has problems with some cases of French Canadian addresses.

Examples This address doesn't parse at all

This one parse but the result is wrong, occupancy is set to None and city is set to bureau 100 Longueuil

Here are some other examples of addresses that do not parse, but seem valid to me, probably because they contain hyphens, parenthesis or something else:

Could you please take a look? My knowledge of regular expressions is very limited

ezzaimsoufiane commented 3 years ago

@phicote im currently facing the same problem, have you found any solution to this?

phicote commented 3 years ago

@phicote im currently facing the same problem, have you found any solution to this?

Hello @ezzaimsoufiane, I haven't found a solution, but my knowledge of regular expressions has improved since that time and I might try to take a look. On the other hand, I do not offer any guarantee of success.

ezzaimsoufiane commented 3 years ago

Hello @ezzaimsoufiane, I haven't found a solution, but my knowledge of regular expressions has improved since that time and I might try to take a look. On the other hand, I do not offer any guarantee of success.

@phicote would very much appreciate it, i'm trying to addapt this to adresses from France.