search

vladimiry / ElectronMail

Unofficial ProtonMail Desktop App
GNU General Public License v3.0
1.51k stars 99 forks source link

Composer window bug (after startup of app) - missing cursor incorrect input recognition #383

Closed itisafrickinhighlander closed 3 years ago

itisafrickinhighlander commented 3 years ago

When I start EM and go to reply/compose an email, there is no visible cursor in the text field. When I start typing it is fine until I hit Enter, it doesn't create a new line, instead it moves the text one line down. Delete would work just fine, backspace would be deleting those new lines, formatting wouldn't work either.

My fix is to click on DB view or just the account tile in the EM sidebar, after that cursor will visually appear again and it will work as it should. Also, I think it goes away eventually, but I have no idea why or how.

Here is a short showcase of this https://user-images.githubusercontent.com/54138438/110292602-c7250180-7fed-11eb-8e96-1a41ad106130.mp4

vladimiry commented 3 years ago

Does the same scenario work well in a regular browser (chrome / chromium)?

itisafrickinhighlander commented 3 years ago

A good thought. I have just tried a Chromium and this bug doesn't manifest there at all, editor works just fine. Same applies to FF, of course. It seems like yet another Electron's specialty. Just as a note, I am using the current release v4.10.2.

vladimiry commented 3 years ago

Kind of OS and app package used?

itisafrickinhighlander commented 3 years ago

OS: Win10 and also Debian 10. EM versions: I tried all starting from the latest down to 4.9.2, all of these showed up this bug.

It will show up right after the startup of app until you, e.g. go to PM settings and back, click on the DB view in EM or just click the tile of the account in EM's control bar.

vladimiry commented 3 years ago

Can confirm that it's reproducible on my side too which should help with the fixing process.

vladimiry commented 3 years ago

Fix has been implemented in df58f0c365614e3935e2cd52a78765a7d0796f40. The change also improves focusing in terms of using the protonmail hotkeys. For example the up/down arrows keys navigation should be working without a need to manually focus the protonmail's mail list view.

vladimiry commented 3 years ago

@itisafrickinhighlander can you verify issue resolving in this build?

itisafrickinhighlander commented 3 years ago

Done, it is fixed in the provided build.

vladimiry commented 3 years ago

One originally enabled change, related to improving initial focus in @protonmail UI, has been lost in v4.12.0 release. The change is not critical but recommended for better UX. For concerned users, the fixed build uploaded here.