search

vladimiry / ElectronMail

Unofficial ProtonMail Desktop App
GNU General Public License v3.0
1.5k stars 97 forks source link

Potential memory leak after batch permanent messages removing #385

Closed vladimiry closed 3 years ago

vladimiry commented 3 years ago

Batch permanent removing was enabled in https://github.com/vladimiry/ElectronMail/releases/tag/v4.9.0:

  • Enable the "Delete permanently" button in the local store view mode (c0b921a, b82215c). In order to prevent accidental data loss, action performing requires 3 mouse clicks to happen. So this feature makes the permanent emails remove action available from any mails list/folder, including the search result (no need to move the emails to the "Trash" folder first). removing

The target is a rendered process that renders the app UI using Angular. Other main/renderer processes doesn't seem to be affected. Other actions other than batch permanent removing don't seem to be casing a noticeable memory leak.

vladimiry commented 3 years ago

Resolved in 4a6c45b.

The fix will very significantly reduce memory leaks in the app's primary/browser-window web/rendering process, followed by triggering some actions in the local store view mode: make read, move to folder, delete permanently (basically any action/event that triggers dynamic folders/mails re-rendering).