search

vladimiry / ElectronMail

Unofficial ProtonMail Desktop App
GNU General Public License v3.0
1.49k stars 96 forks source link

error: Invalid URL protocol, when accessing ProtonDrive #386

Closed edmundlaugasson closed 3 years ago

edmundlaugasson commented 3 years ago

Using ElectronMail 4.11.0 (Flatpak). When opening ProtonDrive, the following error appears:

Unhandled Error
TypeError: Invalid URL protocol
    at default_1.parse (/app/ElectronMail/resources/app.asar/node_modules/@cliqz/url-parser/build/cjs/lib/immutable-url.js:420:23)
    at new default_1 (/app/ElectronMail/resources/app.asar/node_modules/@cliqz/url-parser/build/cjs/lib/immutable-url.js:54:14)
    at new default_1 (/app/ElectronMail/resources/app.asar/node_modules/@cliqz/url-parser/build/cjs/lib/url.js:41:20)
    at Object.depersonalizeProtonApiUrl (/app/ElectronMail/resources/app.asar/app/electron-main.js:7452:10)
    at replacer (/app/ElectronMail/resources/app.asar/app/electron-main.js:7469:41)
    at String.replace (<anonymous>)
    at Object.result [as depersonalizeLoggedUrlsInString] (/app/ElectronMail/resources/app.asar/app/electron-main.js:7470:37)
    at Object.<anonymous> (/app/ElectronMail/resources/app.asar/app/electron-main.js:5499:147)

I understand, that ProtonDrive is for invited users only for now, but it should announce it without such an error. This error appears before that invited users only message comes. I remember, that with earlier versions of ElectronMail, I didn't see such an error.

vladimiry commented 3 years ago

This is a good finding. Fixed in the wip branch. Not promising but a new release might come at the end of the week.

I remember, that with earlier versions of ElectronMail, I didn't see such an error.

The bug was introduced just recently in an attempt to make logged URLs parsed from the raw errors/data more private.