Make 'github-og-image-readme.png' background transparent

vladimiry / ElectronMail

Unofficial ProtonMail Desktop App

GNU General Public License v3.0

1.5k stars 97 forks source link

Closed hwittenborn closed 3 years ago

hwittenborn commented 3 years ago

The current logo image in the README has a white background, which makes the image not blend well when GitHub is on dark mode:

vladimiry commented 3 years ago

The look got worse on white theme but better on dark one. Unfortunately theme-dependent images not yet supported by github (see https://github.community/t/support-theme-context-for-images-in-light-vs-dark-mode/147981/), so it's a trade off for now.

Rudxain commented 2 years ago

Why don't we use an SVG? maybe using the CSS prefers-color-scheme media query would work (SVG supports CSS).

Also, the logo looks worse in dark theme (from an accessibility POV), the black text is barely noticeable, because there's not enough contrast