vladimiry / ElectronMail

Unofficial ProtonMail Desktop App
GNU General Public License v3.0
1.5k stars 97 forks source link

ElectronMail 4.12.2 Will not start on Windows (using latest gen Intel / Ryzen CPU) #412

Closed TBTinker closed 3 years ago

TBTinker commented 3 years ago

Having an issue with ElectronMail v4.12.2 on Windows 10 build 19043.1052 where the application will not start. Clicking the shortcut created by the installer or the main executable itself will result in the program running for about 2 seconds then immediately crashing. Sometimes it will come up with the master password setup screen for a second, but most of the time it comes up as a black window and force closes. This also creates a ghost icon in the taskbar that closes when moused over. Program worked fine before I upgraded my processor from a 2600x to a 5900x.

Windows Event viewer shows this:

Faulting application name: ElectronMail.exe, version: 4.12.2.0, time stamp: 0x605030b6
Faulting module name: ElectronMail.exe, version: 4.12.2.0, time stamp: 0x605030b6
Exception code: 0xc0000409
Fault offset: 0x0000000003b99fff
Faulting process id: 0x2760
Faulting application start time: 0x01d75d74194d8a5f
Faulting application path: C:\Users\Kev\AppData\Local\Programs\ElectronMail\ElectronMail.exe
Faulting module path: C:\Users\Kev\AppData\Local\Programs\ElectronMail\ElectronMail.exe
Report Id: 3097a123-2d00-4094-bab3-d30fe0d49261
Faulting package full name: 
Faulting package-relative application ID: 

Here is what I have tried to remedy the problem to no avail:

Launching via command prompt with --enable-logging only shows this:

(node:15244) DeprecationWarning: file property is deprecated and will be removed in v5.
(Use `electronmail --trace-deprecation ...` to show where the warning was created)

Attached is the logfile created when verbose is set in the config.json log.log

vladimiry commented 3 years ago

Thanks for the detailed report.

The recent https://github.com/electron/electron/releases/tag/v13.1.1 release fixed crashing on latest gen Intel and Ryzen processors. This is likely your case. The v4.12.2 app comes with @electron 13.0.1 (older/lower than v13.1.1).

I think I have saved somewhere the app packages assembled on @electron 13.1.1+. Will share if so for you to test it.

vladimiry commented 3 years ago

The most recent v4.12.3 WIP build assembled from the master branch is uploaded here (the build log is here). This is a WIP/unreleased build, so I don't recommend using it on daily basis but I think it's going to work well. Changes:

TBTinker commented 3 years ago

Thank you for the test build. I can confirm that this build runs properly!

vladimiry commented 3 years ago

Closing the issues as resolved. No code change required since @electron update is already in the master branch. So it's a matter of publishing a new release. Thanks for the thorough report.