search

vladimiry / ElectronMail

Unofficial ProtonMail Desktop App
GNU General Public License v3.0
1.51k stars 99 forks source link

Spell checking broken in macOS #431

Closed ylluminate closed 2 years ago

ylluminate commented 3 years ago

It appears that spell checking no longer works in macOS releases.

vladimiry commented 3 years ago

I won't be able to look into the issue anytime soon as I don't get along with the macOS system.

The spellchecking-related code has not been changed for a long time, so the issue appears to be caused by update of the macOS system or @electron / @chromium.

ylluminate commented 3 years ago

Can I help in some fashion? OpenCore is doing great as well for a lot of people in helping systems to work well. For example, my old MacPro systems from 2009 to 2010 are working great with OpenCore Legacy Patcher running Big Sur+.

vladimiry commented 3 years ago

It appears that spell checking no longer works in macOS releases.

How exactly does the problem manifest itself? Does the spellchecking menu get displayed when you click the right mouse button on the input control? You got the spellchecking context menu but no languages/locales listed to activate one? You got the spellchecking context menu but no correction options listed to pick one?

ELLIOTTCABLE commented 3 years ago

At least under minimal testing, this seems to work fine for me:

Screen Shot 2021-09-07 at 18 02 46

I had to do something unusual-for-macOS, that I assume is an Electron limitation — I had to right-click the text-area and select "Check Spelling" to enable the feature; but after that, it seems passable.

vladimiry commented 3 years ago

Thanks @ELLIOTTCABLE for the input, adding the "glitch" label then.

I had to do something unusual-for-macOS

This is probably because of this menu, and overall the app's spellcheck feature UX was designed and implemented in code in a custom way. The feature in the app required relatively significant work to be done, code designed/written, since at that time @electron didn't have the complete build-in spellcheck implementation. Now @electron has it as a given by @chromium thing but I still tend to think that it's not being very well maintained in @electron (I've observed a list of related issues and some of them still unresolved), so I don't switch the app to it yet (maybe when I switch the UX will be looking more general).

I had to right-click the text-area and select "Check Spelling" to enable the feature

Makes sense I think since the feature is designed to be opt-in partially because the native module/dependency gets involved here and such modules sometimes cause naughty issues, like severe crashes, so I better keep them disabled by default and load lazily/by-demand (when the feature is enabled).

vladimiry commented 2 years ago

Closing as invalid issue.