Maximum call stack size exceeded

[valentinbonneaud]

Hi! I'm on the latest MacOS build and I get the following error message every now and then Maximum call stack size exceeded.

I've multiple accounts set up in my client, let me know if you want more details.

[vladimiry]

There is not enough information to say something specific.

• App version used?
• Can you provide the log.log file's lines related to the error. The file located in the settings folder? You can either attach the log file here or send it privately to the email specified in https://github.com/vladimiry/ElectronMail/blob/master/package.json (author field).
• Is "local store" option enabled for the accounts?
• What is the database.bin file size (located in the settings folder)?
• What is the rough summary number of emails in all accounts (rounding up to thousands is ok)?

[valentinbonneaud]

Sure, let me know if you need more information!

• ElectronMail v4.12.9
• Sent by email ;)
• Local store is activated on my biggest account only, it's off for all the other ones (~10 other accounts)
• The database is ~55Mb
• Total number of emails is roughly ~30-40k

[vladimiry]

Thanks for the details. The log file was helpful in detecting the issue cause. The error gets triggered in the _vacuumIndex function of the https://github.com/ndx-search/ndx library used for indexing the mails for local search. The function uses a recursion technique and the recursion depth has a limit in JavaScript runtime and you hit the limit with so large dataset so the error occurs.

I will see what I can do about that. The simplest option is to stop using the "vaccum" feature of "ndx" library which will end up with the data related to the removed mails to remain in the memory/search-index. The search index is not stored on ssd/hdd but in-memory only so I think this option is acceptable. The more time-consuming option is to rewrite the "_vacuumIndex" function so it doesn't use the recursion technique (recursion algorithms are normally not a great option if scaling matters).

According to the code logic, you should get the error when you remove emails.

The error should go away if you disable the "Full-text search" toggle in the "General" app section.

[vladimiry]

@valentinbonneaud, here is the WIP build for you to test with disabled "search index vacuuming" feature (see the build job link if needed). The build comes with the most recent @protonmail web clients stack (has been updated since v4.12.9). Please report the issue status then.