v4.13.0 cannot start on Windows 7 system - Githubissues

vladimiry / ElectronMail

Unofficial ProtonMail Desktop App

GNU General Public License v3.0

1.5k stars 97 forks source link

v4.13.0 cannot start on Windows 7 system #460

Closed ask2018 closed 2 years ago

ask2018 commented 2 years ago

There seems to be some compatibility regression in version v4.13.0 for Windows I cannot run the program at all with error: "The procedure entry point GetHostNameW could not be located in the dynamic link library WS2_32.dll." v4.12.9 works just fine. OS is Win 7 SP1 x64 Enterprise with all updates, included current 11/2021 ESU updates

ask2018 commented 2 years ago

This seems to be related to Electron 16. Look here - https://github.com/electron/electron/issues/31795

vladimiry commented 2 years ago

This will be a sort of won't fix at this time.

The native modules get compiled at the GitHub Actions CI. The environment is Windows 10 10.0.17763 (Windows 2019).
I don't test the release build on Win7 before publishing and not planning to do so in the future.

This seems to be related to Electron 16. Look here - electron/electron#31795

Thanks. I've just subscribed to the issue. The @electron downgrade, to something lower than 16.7.0, is planned at this time.

vladimiry commented 2 years ago

Will be sharing a build from the https://github.com/vladimiry/ElectronMail/tree/wip-issue-460 branch with downgraded @electron (not releasing but sharing for download).

vladimiry commented 2 years ago

If someone needs it, here is the v14.13.0 build but with downgraded @electron 16.0.0-beta.8 => 15.3.1. The build log is here.

ask2018 commented 2 years ago

Thank you. This build with electron 15.3.1 works again fine.

vladimiry commented 2 years ago

@ask2018 can you test a new build uploaded here?

ask2018 commented 2 years ago

This one seems to be working fine.

vladimiry commented 2 years ago

Thanks. That build apparently includes the https://github.com/electron/electron/issues/31795 related fix (@electron v16.0.0 based build).

ask2018 commented 2 years ago

No problem and thanks for the build. I'm always glad, when people still care about fixing stuff on Win7 :)

vladimiry commented 2 years ago

Hopefully, a final testing build is uploaded here. Since the recently shared build, I had to downgrade 16.0.0 => 15.3.2 due to #461.

ask2018 commented 2 years ago

This build seems to be working fine as well for me. And that high cpu usage issue I didn't have on my system.

vladimiry commented 2 years ago

v4.13.1 has just been released.