Failed to resolve "webclient1://mail.protonmail.com/images/spacer.gif" resource

vladimiry / ElectronMail

Unofficial ProtonMail Desktop App

GNU General Public License v3.0

1.51k stars 99 forks source link

Failed to resolve "webclient1://mail.protonmail.com/images/spacer.gif" resource #472

Closed dhbtfs closed 2 years ago

dhbtfs commented 2 years ago

Hi there,

I am getting this error every now and then, red big banner on top of page of my email.
Can you please clarify if this is a bug or something?

Thanks

vladimiry commented 2 years ago

What are the reproduction steps (could not reproduce it yet)?

I was not able to locate spacer.gif file nor references to it in https://github.com/ProtonMail/WebClients.

dhbtfs commented 2 years ago

Screenshot 2021-12-14 001811 Screenshot 2021-12-14 193242

When I open an email with allow images to be loaded, I get this error. Using latest version,

vladimiry commented 2 years ago

Thanks for the details. The issue is still reproducible at my side.

Do you face this error message opening any email regardless of the sender or do you get the error for specific emails only (like only for an email from ICloud)?
If there is no private information, consider forwarding the email message you tested the issue on to the email specified in the "author" section of the package.json# file.

The blind guess is that you get the error for specific html emails only where the spacer.gif image is embedded with a relative address rather than a full/domain-based address. The guess is based on the point I posted before:

I was not able to locate spacer.gif file nor references to it in https://github.com/ProtonMail/WebClients.

dhbtfs commented 2 years ago

WRONG INFO:
Not only from iCloud. I also get the error when I open Humble Bundle. This is a relatively new account and I get few emails and I delete emails regularly. So far, only checked HB I have now.
Correction: I get the error when I open Humble Bundle. This is a relatively new account and I get few emails and I delete emails regularly. So far, only checked HB I have now.

I do not know how to do text with cross over it on github so I had to do it this way.

I will forward that emails right away. You should get them by the same name as here.

vladimiry commented 2 years ago

Thanks for sending a problematic email for review. The guess I posted above, about using image with relative address in the HTML email content was correct as the received email contains images with src="images/spacer.gif" address. So the problem in fact lies at the Humble Bundle side as they form email content in a sloppy way (relative images use).

So the app works as designed. What I could do here is to stop showing the error message to a user in the cases like (done in https://github.com/vladimiry/ElectronMail/commit/7cab9cc13361d0aa4b6797c54175468e82b6cbc3). The new app version won't annoy you anymore.