vladimiry / ElectronMail

Unofficial ProtonMail Desktop App
GNU General Public License v3.0
1.5k stars 97 forks source link

Unhide options tab #475

Closed chief-1buk closed 2 years ago

chief-1buk commented 2 years ago

Hello,ElectronMail-1 I am using ElectronMail (Protonmail) on macOS and "hid" the options tab at the top and now I am unable to re-enable it. Can someone advise how i can re-enable this Options tab?

Thank you, chief-buk ElectronMail v4.13.17170eaa Unofficial ProtonMail Desktop App Distributed under GPL-3.0 license.

vladimiry commented 2 years ago

You can reach the "general" app's settings tab via the tray menu and there you can toggle the "Hide controls bar" control (also notice F12 hotkey related toggle near to this control).

chief-1buk commented 2 years ago

Ok, I am unsure where the "tray menu" is located, but I used Control/F12 and the Options tab is shown again.

If possible, can you advise if there is a method to stop/disable showing the email address when hovering the mouse/pointer over a clickable link in an email message? (see attached screen shot) Eectron email header-R-2

vladimiry commented 2 years ago

If possible, can you advise if there is a method to stop/disable showing the email address when hovering the mouse/pointer over a clickable link in an email message?

There is no option in the app that would allow you to disable this feature.

chief-1buk commented 2 years ago

So, it's not possible by some other method?

vladimiry commented 2 years ago

So, it's not possible by some other method?

It's currently possible only if you are ok to deal with changing a source code and assembling own app package.

chief-1buk commented 2 years ago

Ok, lets do it.

vladimiry commented 2 years ago

Ok, lets do it.

This will likely take you hours since the app package assembling process includes building the https://github.com/ProtonMail/WebClients stuff.

1) See how to build the app https://github.com/vladimiry/ElectronMail#how-to-build-your-own-installation-package-from-source-code. So 2 options: via cloning the project and then building via CI system or local build. I don't provide an entry level guidance, so you will likely need some programming/technical skills. 2) If you want to completely remove links highlighting remove the following code https://github.com/vladimiry/ElectronMail/blob/83f63e0645f47baab50a2f1ea952479467b682cb/src/electron-main/web-contents.ts#L245-L270 3) If you only need to disable email links highlighting add the following code

            if (url && isEmailHref(url)) {
                IPC_MAIN_API_NOTIFICATION$.next(
                    IPC_MAIN_API_NOTIFICATION_ACTIONS.TargetUrl({url:""}),
                );
                return;
            }

after this line https://github.com/vladimiry/ElectronMail/blob/83f63e0645f47baab50a2f1ea952479467b682cb/src/electron-main/web-contents.ts#L245

BeiBarBoy commented 11 months ago

Sorry to reopen this, but having the same issue of being unable to show the Options bar again after hiding it under MacOS... I tried pressing F12 and Control-F12 (after enabling the standard function keys), nothing happens. How can I resolve this? It's driving me crazy as I want to change my Proton account and can't.

Thanks.

ElectronMail v5.2.0.8b54e69

vladimiry commented 11 months ago

@BeiBarBoy, F12 supposed to work, but I can't test it on macOS at this time.

You can also make the controls bar back by disabling the "Hide controls bar" toggle located in the app "General" settings block. How to access the "Settings" dialog having controls bar hidden - via the respective tray menu item. Finally, you can manually modify config.json settings file by setting hideControls: false value. Settings

BeiBarBoy commented 11 months ago

Am going to try again with your directions, but as I have no menu bar or side bar, I don't even see the app General settings block you mention !

Am happy to start again from 0, but I can't seem to uninstall the app completely. Some settings storage remains somewhere as, when I uninstall (using an uninstaller app) and reinstall, I return to the same settings, with the same Proton account and the same window without any menu or side bar.

vladimiry commented 11 months ago

but as I have no menu bar or side bar, I don't even see the app General settings block you mention !

How to access the "Settings" dialog having controls bar hidden - via the respective tray menu item.

BeiBarBoy commented 11 months ago

Solved by editing config.json. Thanks for the directions and sorry for the hassle.