URL Does Not Open In Browser

vladimiry / ElectronMail

Unofficial ProtonMail Desktop App

GNU General Public License v3.0

1.51k stars 99 forks source link

URL Does Not Open In Browser #493

Closed DebSec closed 2 years ago

DebSec commented 2 years ago

ElectronMail v4.13.3 on Linux Mint

Links or URL's when clicked on do not prompt to open in browser?

Not sure if this is on my end only.

vladimiry commented 2 years ago

What kind of URLs (a screenshot would be helpful)?

Btw, I'd suggest to review #45.

DebSec commented 2 years ago

ElectronMail v4.13.4 on Linux Mint. The issue was not there on ElectronMail v4.13.2 and prior releases. Any link or url when left clicked on has no action. If I hover over the URL it is displayed but performs no action now. It has always opened up the link in my browser. Right clicking will copy the url address and I can place it in the address bar of my browser.

vladimiry commented 2 years ago

I can confirm the issue. Didn't do any debugging yet but it's clear that @protonmail has changed something in their https://github.com/ProtonMail/WebClients.

Workarounds:

Copying the link address via context menu.
Enabling the "Link confirmation" feature in the proton settings ("General" section). The links still get open in browser via the confirmation dialog.
Using v4.13.2 which comes with working https://github.com/ProtonMail/WebClients version (outdated though).

vladimiry commented 2 years ago

What about this build? Will be publishing a new release if this build works well.

vladimiry commented 2 years ago

The fix has been released in v4.13.5. Thanks for placing the issue with provided detailed explanation.

DebSec commented 2 years ago

v4.13.5 is working fine as far as the hyperlinks not working correctly. Thank you for your time and I really appreciate your efforts. Stay safe.