search

vladimiry / ElectronMail

Unofficial ProtonMail Desktop App
GNU General Public License v3.0
1.5k stars 99 forks source link

Adding a pitch black night mode #510

Open sallyFoster opened 2 years ago

sallyFoster commented 2 years ago

Hey I just stumbled into your app, and I really like it, but I was wondering if you could add an ever darker mode than the one you have. Instead of aqua blue, can you make it pitch black night mode, or at least add an even darker option?

Screen Shot 2022-04-28 at 4 51 40 PM
sallyFoster commented 2 years ago

@vladimiry Did you get a chance to see this feature request?

vladimiry commented 2 years ago

Yes, I've seen the request. Enhancing the dark mode feature is not on my immediate TODO list.

macbugs commented 2 years ago

I dont see an "aqua blue" theme. The currently supported dark themes are Carbon & Monokai. Both appear darker on my platform than the theme used in your screenshot.

themes2

dark theme2

There may be some inconsistency in how themes are rendered on different platforms. Please report your OS version and ElectronMail version. Also, if your theme palette is different than the one displayed here, give us a screenshot of that.

vladimiry commented 2 years ago

the theme used in your screenshot.

The original screenshot is the app's dark theme (specifically displaying the local store view mode), not the proton's one.

macbugs commented 2 years ago

ok, I see the color change in that mode. But I also see another issue here: when I activate the local storage feature, I can see in my traffic monitor that it does download something, and the size of database.bin has increased by several megabytes -- but when the download completes and the activity/sync indicator stops blinking, if I re-launch the app without an internet connection, it says "loading local store", but defaults to online mode. When I switch to offline mode, no mail is displayed until the connection is restored.

offline2 reconnect

vladimiry commented 2 years ago

it says "loading local store", but defaults to online mode.

The "loading local store" progress bar indicates the process of decrypting the database.bin and loading it to the memory in full.

When I switch to offline mode, no mail is displayed until the connection is restored.

This is a good finding. The local store feature was originally designed as something that enables access to the email messages in the offline mode, and it worked this way before. So this is a bug.

vladimiry commented 2 years ago

So this is a bug.

Should be resolved by https://github.com/vladimiry/ElectronMail/commit/05fe5684993f7aa8e1bb3fdb2291dc47c8b48019 (wip branch).

sallyFoster commented 2 years ago

Is this talk related to adding a black mode on the local store view mode?

vladimiry commented 2 years ago

No. That was about fixing local store view mode availability in offline mode.