search

vladimiry / ElectronMail

Unofficial ProtonMail Desktop App
GNU General Public License v3.0
1.5k stars 96 forks source link

Add dynamic version number of deployment types to main github page #519

Closed knakamura8 closed 2 years ago

knakamura8 commented 2 years ago

Hello! I am wondering if perhaps there is a way of adding dynamic version information next to the different build types on the main github page. For example, Flatpak is currently at version 5.0.0, yet the unofficial snap is currently at version 4.15.0. You have to click on each of the deployment links on the main github page to determine this, however.

I think it would be convenient to have some organized grid where one could quickly see the highest level version currently offered by each deployment type.

vladimiry commented 2 years ago

It's noted on the https://github.com/vladimiry/ElectronMail#download section that available repositories get handled by different maintainers. This means that normally Snap/AUR/Makedeb repos get updated 1-2 days later. The flatpak & choco repos maintained by me, so normally get updated faster.

I don't think that a few days delay is a big deal, so closing the issue with won't fix status.

If you want to be among the first users who get a new release, just subscribe to releases notification using the "Watch" button here on GitHub (you would select the "custom => releases" option from the dropdown list attached to this button).

CC @joshirio, @hiddeninthesand.

knakamura8 commented 2 years ago

Sure, I am aware that they take a few days, it is not a problem for me. I just thought it might be convenient to have a version grid is all :) Anyway, thank you for all your hard work (as well as for the rapid response!).

vladimiry commented 2 years ago

I just thought it might be convenient to have a version grid is all

That would be on the repo system to provide the dynamic image badge with version number embedded in it.

knakamura8 commented 2 years ago

Badgen and shields appear to satisfy the requirements. Again, low priority, but just in case you were curious. Cheers, and have a good day!

knakamura8 commented 2 years ago

Here are badges (I am unaware of a service for makedeb, but this covers AUR, snapcraft, flathub, and Chocolatey):

![AUR version](https://img.shields.io/aur/version/electronmail-bin)
![Snapcraft version](https://badgen.net/snapcraft/v/electron-mail)
![Flathub version](https://img.shields.io/flathub/v/com.github.vladimiry.ElectronMail)
![Chocolatey version](https://img.shields.io/chocolatey/v/electron-mail)
vladimiry commented 2 years ago

Yes, this is what I meant. Do a pull request if you want to get listed on https://github.com/vladimiry/ElectronMail/graphs/contributors, or I will update the readme page in my own, likely tomorrow.

vladimiry commented 2 years ago

Do a pull request

Makedeb repo badge is missing in the list. So we would need a similarly styling generic badge for Makedeb repo, but apparently static for now.

knakamura8 commented 2 years ago

Yup, I noticed that, and made an Issue there. There seems to be some way to use badgen to make a custom badge with makedeb's API, and I will look into perhaps in several hours.

knakamura8 commented 2 years ago

Yes, this is what I meant. Do a pull request if you want to get listed on https://github.com/vladimiry/ElectronMail/graphs/contributors, or I will update the readme page in my own, likely tomorrow.

Sure, no problem, either way is fine. I can just make a PR for you within a day or two. Again, thank you so much for your work on this project!

vladimiry commented 2 years ago

Let's wait for PR then. There is no rush.

knakamura8 commented 2 years ago

@hiddeninthesand It appears as though makedeb requires an endpoint. Looking at makedeb's API, it appears as though an endpoint may then simply be passed through badgen as a request such as https://badgen.net/https/mpr.makedeb.org/api/electronmail-bin/makedeb

hiddeninthesand commented 2 years ago

I believe the feature OP is looking for is a Repology embed in the README. You can see an example of the embed on the site, or a working example on a GitHub repository like scrcpy's (even though I think they have an excessive amount of package repositories listed). You can see ElectronMail's Repology page here.

knakamura8 commented 2 years ago

Hello! Well, the issue with repology is that it's another thing that has to be clicked on, rather than quickly available as badges, and it currently only shows AUR, homebrew cask, MPR, then some nix packages and pacstall. Nothing about Flathub or Snapcraft. It does integrate with MPR, however! Thank you! That should cover everything. I'll make a quick PR later, feel free obviously to reject or accept, no worries either way :) Cheers!

hiddeninthesand commented 2 years ago

Well, the issue with repology is that it's another thing that has to be clicked on, rather than quickly available as badges

Repology supports badges, which I mentioned previously. No requirement for anything to be clicked on, just another source of badges like https://shields.io

Nothing about Flathub or Snapcraft.

This does actually seem to be a rather unfortunate obstacle. By their own words: Repology does not support self-contained blobs like flatpaks, which require versions of all bundled components to be considered.

Using it strictly for the makedeb badge would seem to fix the current API issue though, glad I could help.

knakamura8 commented 2 years ago

Submitted a PR with all known package types https://github.com/vladimiry/ElectronMail/pull/520