search

vladimiry / ElectronMail

Unofficial ProtonMail Desktop App
GNU General Public License v3.0
1.51k stars 99 forks source link

Unhandled Error: TypeError: No protocol #525

Closed ystxn closed 2 years ago

ystxn commented 2 years ago

This sometimes pops up while replying to an email and requires dismissing several times. Not sure if it's related to the contents of the mail being replied to, but it should fail gracefully since the message can be sent after dismissing the error.

Error Screenshot

Windows 11 21H2

vladimiry commented 2 years ago

but it should fail gracefully since the message can be sent after dismissing the error.

If this doesn't affect the functionality, then yes, sure it should fail gracefully. The thing is that by default, no URL's without protocol expected to be there (I would be interested in reproducing this case at my side). Anyway, I'm going to try/catch this place, log the URL's "origin" value, and fail gracefully. Thanks for the report.

vladimiry commented 2 years ago

Anyway, I'm going to try/catch this place, log the URL's "origin" value, and fail gracefully.

Besides, I think I should ban such kind of requests. At least until I figure details.