vladimiry / ElectronMail

Unofficial ProtonMail Desktop App
GNU General Public License v3.0
1.5k stars 96 forks source link

Add Winget badge #538

Closed sitiom closed 2 years ago

sitiom commented 2 years ago

Add Winget badge in README. I used a custom query to https://repology.org/project/electronmail/versions since shields.io doesn't support Winget badges yet. (https://github.com/badges/shields/issues/5548)

vladimiry commented 2 years ago

I will need to mention a repo maintainer (preferably GitHub username). Is this @sitiom?

sitiom commented 2 years ago

There isn't a sense of a maintainer in https://github.com/microsoft/winget-pkgs as it is a central repository where anyone can contribute, but most automatic updates are handled by @vedantmgoyal2009 in his automation repo (https://github.com/vedantmgoyal2009/vedantmgoyal2009) or from software vendors themselves using the Winget Releaser action or something similar.

I have added ElectronMail to @vedantmgoyal2009's automation in https://github.com/vedantmgoyal2009/vedantmgoyal2009/pull/709. This is how you would want it to be, right?

vladimiry commented 2 years ago

This is how would want it to be, right?

Yes, it appears so.

vedantmgoyal9 commented 2 years ago

Can you please use winget-releaser? Due to >1000 packages, GitHub's API rate limit is exceeded and packages are not able to update. That's why I have developed an action so the software developers are able to maintain themselves and non-GitHub packages are able to update.

vladimiry commented 2 years ago

Can you please use winget-releaser?

This is a relatively small burden (automated stuff), but still at this time I'm not ready to accept it. See details in #537.

vladimiry commented 2 years ago

Merged manually, see 2043c52cdcf66df006c921753573b0ff64635d99.