vladimiry / ElectronMail

Unofficial ProtonMail Desktop App
GNU General Public License v3.0
1.49k stars 96 forks source link

New Calendar Button not working #579

Open tarkett2018 opened 1 year ago

tarkett2018 commented 1 year ago

With the new(?) Version from Proton Mail Client I see on the right panel a new Button for the Calendar, but it doesn't work with ElectronMail. In the Browser it works fine and open the Calendar.

Bild 002

Following errors in the logfile:

[2023-01-18 19:16:36.360] [error] src\electron-main\web-contents.ts {"level":3,"message":"Access to fetch at 'https:///auth/info' from origin 'webclient://calendar.proton.me' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.","line":0,"sourceId":"webclient://calendar.proton.me/"} [2023-01-18 19:16:36.375] [error] src\web\browser-window\app_accounts\account-view.component.ts AccountViewComponent webview event {"type":"console-message","level":3,"message":"Access to fetch at 'https:///auth/info' from origin 'webclient://calendar.proton.me' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.","line":0,"sourceId":"webclient://calendar.proton.me/"}

vladimiry commented 1 year ago

Thanks for the report. I didn't notice this new feature before publishing the 5.1.3 release and so didn't try it in action.

vladimiry commented 1 year ago

There is no easy fix as they use iframe for embedding the entire calendar web app on the side panel vs mounting calendar-related components into the same page/DOM.

tarkett2018 commented 1 year ago

Thanks for the analyze. Maybe in future Releases will it work šŸ‘ šŸ‘ šŸ‘

rauldipeas commented 1 year ago

Any news on this issue?

vladimiry commented 1 year ago

I tried some ideas in wip-drawer-iframe branch, but it remains incomplete. I don't know when I try again. Fighting iframes is a sort of boring thing to do. No need to ask for news, you will see some if there are any.

GoldenGlimpse commented 1 year ago

Is this the same reason why Proton Drive doesn't work?

vladimiry commented 1 year ago

Is this the same reason why Proton Drive doesn't work?

It's not. Drive supposed to work, for long time. Try relogin if it doesn't.

GoldenGlimpse commented 1 year ago

It's not. Drive supposed to work, for long time. Try relogin if it doesn't.

Drive stopped working for me since version v5.1.7 i believe. I hoped it would work after an update which i just did, but still no luck. I get stuck on the page !Something went wrong and have to relogin to solve it.

edit: seems to be solved now somehow.

PegHorse commented 3 months ago

The bug occur again with same error message in the log.

vladimiry commented 3 months ago

It was not fixed, so of course it occurs again. I mean the calendar button issue.

PegHorse commented 3 months ago

Did you drop that bug or will you fix it ?

vladimiry commented 3 months ago

I mean the calendar button issue.

Did you drop that bug or will you fix it ?

This issue remains open, so there is a chance for it to get fixed one day. But I'm not ready for another attempt, iframe stuff is a mess to work with. There is still a hope that Proton converts iframe use for calendar embedding to a regular single page application approach, how it's supposed to be these days, so then the issue gets self-resolved.