search

vladimiry / ElectronMail

Unofficial ProtonMail Desktop App
GNU General Public License v3.0
1.49k stars 98 forks source link

Cannot load remote images with tracker protection #598

Closed technotiger closed 1 year ago

technotiger commented 1 year ago

The error appears for every email containing remote images. The error cross mark is shown in place of all remote images. MacOS x64.

Message "Some images could not be loaded with tracker protection." appears on the top as shown. Pressing the Load button loads the images (without protection).

Screen Shot 2023-03-13 at 6 21 20 PM

Issue first appeared after recent update. I do not remember the previous version on which it worked. Reverting to 5.1.4 and 5.1.3 did not help. If I try to go back further, login no longer works.

Images load fine (with protection) when using ProtonMail in Safari on the same machine.

vladimiry commented 1 year ago

Confirmed. To fix this, the packaged into the app web client apps stack has to get addition patching. So new app release coming soon. Most likely issue arrived with v5.1.4 app release, due to the updated web client apps stack, but missed patching extending.

vladimiry commented 1 year ago

I've got it fixed and running an updated version locally, so a new release is on the way.

The issue generally looks to me as a bug of @ProtonMail as for some reason they don't respect the API_URL const (build-time value defied in src/app/config.ts) for core/v4/images and core/v4/images/logo API calls. So going to place issue in https://github.com/ProtonMail/WebClients/issues tracker.

vladimiry commented 1 year ago

Should be fixed in just released v5.1.6.

technotiger commented 1 year ago

Issue resolved in v5.1.6. Confirmed. Thank you!

vladimiry commented 1 year ago

I patched the web client to resolve the issue, but also placed the issue at the proton side.