vladimiry / ElectronMail

Unofficial ProtonMail Desktop App
GNU General Public License v3.0
1.49k stars 98 forks source link

Error: App version outdated #603

Closed Nickwasused closed 1 year ago

Nickwasused commented 1 year ago

      This issue is the same as #588. You don't need to confirm the issue or sent your system details.      

Info

Version: Electronmail v5.1.6 OS: Windows 10

ElectronMail_ikEHKAqVab

Log

[2023-04-04 10:22:31.994] [error] src\electron-main\web-contents.ts {"level":3,"message":"Uncaught (in promise) AppVersionBadError: App version outdated","line":35443,"sourceId":"webclient://mail.proton.me/index.f197a8ad.js"}
[2023-04-04 10:22:31.995] [error] src\electron-main\web-contents.ts {"level":3,"message":"Uncaught (in promise) AppVersionBadError: App version outdated","line":35443,"sourceId":"webclient://mail.proton.me/index.f197a8ad.js"}
[2023-04-04 10:22:31.998] [error] src\web\browser-window\app\_accounts\account-view.component.ts AccountViewComponent webview event {"type":"console-message","level":3,"message":"Uncaught (in promise) AppVersionBadError: App version outdated","line":35443,"sourceId":"webclient://mail.proton.me/index.f197a8ad.js"}
[2023-04-04 10:22:31.998] [error] src\web\browser-window\app\_accounts\account-view.component.ts AccountViewComponent webview event {"type":"console-message","level":3,"message":"Uncaught (in promise) AppVersionBadError: App version outdated","line":35443,"sourceId":"webclient://mail.proton.me/index.f197a8ad.js"}
[2023-04-04 10:22:32.020] [error] src\electron-main\web-contents.ts {"level":3,"message":"Uncaught (in promise) AppVersionBadError: App version outdated","line":35443,"sourceId":"webclient://mail.proton.me/index.f197a8ad.js"}
[2023-04-04 10:22:32.022] [error] src\web\browser-window\app\_accounts\account-view.component.ts AccountViewComponent webview event {"type":"console-message","level":3,"message":"Uncaught (in promise) AppVersionBadError: App version outdated","line":35443,"sourceId":"webclient://mail.proton.me/index.f197a8ad.js"}
NintendoManiac64 commented 1 year ago

If it makes any difference, I'm getting the exact same error here on Linux Mint 20.3 with the flatpak (also v5.1.6 as of this comment):

itisafrickinhighlander commented 1 year ago

We are all getting it now. PM pushed a new update to their web client. It happened a month ago, too. See https://github.com/vladimiry/ElectronMail/issues/588. OP already know the ordeal, just letting Vladimiry know. It looks like this will be a reoccurring theme and EM can just adjust to it every time.

vaportail commented 1 year ago

Ehh.. @ProtonMail could give some grace period for version updates. Or make their own windows client (and no, Proton Bridge does not count). I have a paid account and yet can't use it properly without annoyance every couple months/weeks.

perfectpassage commented 1 year ago

Getting the same issue using Linux Debian 11. I re-installed 5.1.6. Still no luck resolving it.

itisafrickinhighlander commented 1 year ago

Ehh.. @ProtonMail could give some grace period for version updates. Or make their own windows client (and no, Proton Bridge does not count). I have a paid account and yet can't use it properly without annoyance every couple months.

I get your point, but you are asking for a company to change their release method just so that a third-party client doesn't break. I agree that this is annoying and gives Vladimiry an impromptu work every once in a while, but if PM chose this deployment method, then there was a reason and it is done so that their 1st party access method (web) is always up-to-date.

vladimiry commented 1 year ago

New release coming soon.

ask2018 commented 1 year ago

I'm not sure if that possible somehow easily with current code, but when I have seen the comments above about PM should give some grace period for version updates, Ive got this idea. How about implement possibility to auto/manual update the Protonmail client from the web inside ElectronMail similar how it is done inside browser? Then we don't need update each time PM will do some breaking change. Is that maybe possible/safe solution @vladimiry?

vladimiry commented 1 year ago

@ask2018, there is a tight & sensitive integration layer between the app and proton's web client. You can update the web client or load a live version from the internet, but then the integration might get broken. Besides, currently, the web client update normally includes a need to update its patching. So, aside from other things, like preventing proton to independently update the web client version used in the app (a privacy/security matter), a static web clients apps stack packed into the app makes it sure that the integration doesn't get broken with web client update.

The workaround you have is using the service via a web browser, the official way.

ask2018 commented 1 year ago

Thank you for detailed explanation @vladimiry and I understand. Well the workaround via web browser is of course always here but that I count just for emergency usage. For regular usage webbrowser is really pain in the ass for email. But it is not a big deal wait few hours or days for updated version. I just thought it might be less work for you and less pain for users if such breaking changes will be now more often from PM side, because it has been just few weeks from similar case.

vaportail commented 1 year ago

@ask2018 what I meant with grace period is, allow non-critical updates to still allow "outdated" frontend to work, instead of just showing an error page. Shouldnt be too hard to implement, proton-side. Of course if a critical security fix is introduced it should totally block old fe versions from running.

Looks like the new build is almost finished tho

ask2018 commented 1 year ago

@vaportail Yeah I know and I agree probably not too hard to implement from their side, but I doubt Proton company cares much if it breaks unofficial client.

fosko commented 1 year ago

Same issue, but being @vladimiry already on it I have no worries. Cheers.

vladimiry commented 1 year ago

Should be fixed in v5.1.7.