search

vladimiry / ElectronMail

Unofficial ProtonMail Desktop App
GNU General Public License v3.0
1.49k stars 98 forks source link

issues downloading large files from Drive #638

Closed TimmyBoi155 closed 1 year ago

TimmyBoi155 commented 1 year ago

I am trying to download a file that is a bit over 2 GB, and I get this message from proton drive:

"Browser might run out of memory Your current browser does not support the downloading of large files due to the unavailability of service workers. Downloading large files may freeze or leave the browser unresponsive. Please use the latest versions of a recommended browser and try again."

I tried to download it anyway but when i save the file to a directory after it downloads, it does not show up in the directory.

I looked around for an issue for this but couldnt find one, so I apologize if one was already made

vladimiry commented 1 year ago

Good finding.

There is a TODO which is not fulfilled yet, and so the recent service worker script location change by @protonmail, which is an issue cause, didn't get automatically noticed.

The issue got fixed in the wip branch by bfae0c6. Not sure yet if I will be promptly publishing a new release due to this fix.

Also, I made sure if service worker script location gets changed again, it gets automatically noticed in the build pipeline and releasing gets blocked until the issue is fixed.

vladimiry commented 1 year ago

@TimmyBoi155, can you test the build uploaded here? If it runs well, I'm going to publish it as v5.2.1 release.

TimmyBoi155 commented 1 year ago

sorry for the late reply. yeah will test and get back in a bit @vladimiry

TimmyBoi155 commented 1 year ago

seems to work great. it did not give me the warning like last time. I downloaded a file over 3GB no issue :) and a 10GB file as well @vladimiry

vladimiry commented 1 year ago

@TimmyBoi155 thanks, new release is on its way.