search

vladimiry / ElectronMail

Unofficial ProtonMail Desktop App
GNU General Public License v3.0
1.48k stars 96 forks source link

Proton Pass not working #645

Open ajgringo619 opened 8 months ago

ajgringo619 commented 8 months ago

App is working great so far. My only issue is that Proton Pass does not load - nothing happens at all when I click the app. Since this is very new, is there something I need to do on my end to get it working? I noticed from the web client that it required a Chrome extension.

vladimiry commented 8 months ago

The app by design loads the WebClients as a packaged into the app static bundle with applied patches, not from the web. There are many reasons for this approach. So there is a need to look into that Pass and make it packaged into the app too.

I'm not convinced yet that I'm ready for enabling Chrome extensions support in the app. So if the Pass requires extensions support, this will be an addition reason for it not being functional within the app.

Generally, I believe it's not the best idea to enable Pass support in the app or using it in the browser, as services like Pass better to be used as an independent/standalone app to reduce possible attack vectors via extra functionality.

ajgringo619 commented 8 months ago

OK, that makes sense.