Mac CMD+F does not work

[tombarys]

Hi, Cmd+F shortcut does not work. I am frequently adding and using e-mail filters and I need to search through the page with them to skip to them quickly. Is any way how to do it? Thanks in advance! Tomáš

[vladimiry]

The requested feature is not implemented at this moment.

[tombarys]

Ok, I understand, thanks. Tomáš

––––––––––––– Tomáš Baránek http://barys.me tom@barys.me

TIP: nechcete-li, aby poskytovatel mailu či někdo jiný mohl zneužít obsah vašich zpráv, zkuste skvělý švýcarský šifrovaný ProtonMail.com.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ středa 26. prosinec 2018 16:08, Vladimir Yakovlev notifications@github.com napsal:

The requested feature is not implemented at this moment.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[vladimiry]

The pre v2.1.0 version with Cmd+F feature included is uploaded here. This version also got https://github.com/vladimiry/email-securely-app/issues/86 resolved.

Electron doesn't provide a complete built-in solution for Cmd+F thing. My implementation is a bit tricky and there is an issue I'm still to sort out: when I was testing the feature the app process got hanged a few times with high CPU use and I had to kill the process. It seems to be working in general but I'm interested in revealing possible issues apart of the hanged app process. @tombarys, can you try it?

The feature is disabled by default as for now and marked with experimental label due to the above-mentioned issue.

See how to enable the feature:


[vladimiry]

I figured why the process was hanging, no easy fix available though.

[tombarys]

Hi, Vladimir, thanks. Just trying, but pressing CMD+F "does nothing". It does not hang and it does not offer any search dialog or anything...

(MacBook Pro Touch, Mojave 10. 14. 2.).

Thanks! T.

––––––––––––– Tomáš Baránek http://barys.me tom@barys.me

🔐 TIP: nechcete-li, aby poskytovatel mailu či někdo jiný mohl zneužít obsah vašich zpráv, zkuste skvělý švýcarský šifrovaný ProtonMail.com.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ sobota 29. prosinec 2018 19:25, Vladimir Yakovlev notifications@github.com napsal:

I figured why the process was hanging, no easy fix available though.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[tombarys]

Sorry!!! My mistake! I forgot to switch the option ON. Sorry for that.

It works, it has not hung yet.

Just asking: I miss other behaviours:

• CMD-A (for selecting "all") too for editing in forms (search etc.) and especially when deleting whole email ...
• when using TextExpander (= I am a heavy user), it does not expand the snippets, just deletes the text I am using for initiating expansion

Thanks a lot! Tomáš

––––––––––––– Tomáš Baránek http://barys.me tom@barys.me

🔐 TIP: nechcete-li, aby poskytovatel mailu či někdo jiný mohl zneužít obsah vašich zpráv, zkuste skvělý švýcarský šifrovaný ProtonMail.com.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ sobota 29. prosinec 2018 20:24, Tomáš Baránek tom@barys.me napsal:

Hi, Vladimir, thanks. Just trying, but pressing CMD+F "does nothing". It does not hang and it does not offer any search dialog or anything...

(MacBook Pro Touch, Mojave 10. 14. 2.).

Thanks! T.

––––––––––––– Tomáš Baránek http://barys.me tom@barys.me

🔐 TIP: nechcete-li, aby poskytovatel mailu či někdo jiný mohl zneužít obsah vašich zpráv, zkuste skvělý švýcarský šifrovaný ProtonMail.com.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ sobota 29. prosinec 2018 19:25, Vladimir Yakovlev notifications@github.com napsal:

I figured why the process was hanging, no easy fix available though.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[vladimiry]

• CMD-A (for selecting "all") too for editing in forms (search etc.) and especially when deleting whole email ...

Opened separate issue https://github.com/vladimiry/email-securely-app/issues/90.

[vladimiry]

The in page search feature now works as the following:

• Feature is only available within account's page. So if you have no accounts added to the app then Ctrl+F hotkey will take no effect.
• The search window will be automatically closed on switching between accounts.
• Search window will be automatically closed on switching to the database view mode. Ctrl+F hotkey takes no effect while in database view mode. Database view mode is going to get its own full-text search, one day.
• The main app process doesn't hang anymore. It was hanging because findInPage hangs trying to highlight matches in invisible webview. Unfortunately webview can't be taken out from DOM as it gets reloaded if re-attached back to DOM (another Electron's issue). In my opinion it should not search through the hidden elements in the first place. Currently Electron doesn't provide an option to explicitly filter out some elements from searching (like by CSS selector), see respective issue.

Build uploaded here has been updated. @tombarys can you try it? If it works well and as described, then I think this is going to be a settled for the next release implementation.

TextExpander

What is TextExpander, screesnhot?

[tombarys]

Hi, thanks, I am just installing the new build.

The TextExpander is an app used for text expansions – https://textexpander.com/download/.

Best

––––––––––––– Tomáš Baránek http://barys.me tom@barys.me

🔐 TIP: nechcete-li, aby poskytovatel mailu či někdo jiný mohl zneužít obsah vašich zpráv, zkuste skvělý švýcarský šifrovaný ProtonMail.com.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ neděle 30. prosinec 2018 11:04, Vladimir Yakovlev notifications@github.com napsal:

The in page search feature now works as the following:

• Feature is only available within account's page. So if you have no accounts added to the app then Ctrl+F hotkey will take no effect.
• The search window will be automatically closed on switching between accounts.
• Search window will be automatically closed on switching to the database view mode. Ctrl+F hotkey takes no effect while in database view mode. Database view mode is going to get its own full-text search, one day.
• The main app process doesn't hang anymore. It was hanging because findInPage hangs trying to highlight matches in invisible webview. Unfortunately webview can't be taken out from DOM as it gets reloaded if re-attached back to DOM (another Electron's issue). In my opinion it should not search through the hidden elements in the first place. Currently Electron doesn't provide an option to explicitly filter out some elements from searching (like by CSS selector), see respective issue.

Build uploaded here has been updated. @tombarys can you try it? If it works well and as described, then I think this is going to be a settled for the next release implementation.

TextExpander

What is TextExpander, screesnhot?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[vladimiry]

The TextExpander is an app used for text expansions – https://textexpander.com/download/.

At this moment I don't have the capacity to support third-party tools, but you can open a separate issue if you want.

Closing as resolved. The feature will be a part of the next release.