search

vladionescu / keybase-gitea-bot

Based on Keybase's Gitlab bot. Notifications in Keybase Teams for Gitea, using webhooks.
MIT License
3 stars 3 forks source link

config enhancements, gitea library update, and ability to DM #2

Closed traetox closed 4 years ago

traetox commented 4 years ago

This PR has a few enhancements that work well for us:

  1. Update version of gitea structs library to get access to HTML URLs in messages
  2. Add ability to specify config via a config file (still fully supports flags). This is nice for stuffing secrets in via docker secrets
  3. Add new directive to enable direct messages on actions. The config file supports a mapping so that you can map a gitea username to a keybase username and then tick a flag so that issues, PRs, etc. will be direct messaged to assignees rather than just blasting a single channel. Helps a ton when working in large groups.
  4. Added support in messages for the assignees member. Newer gitea allows for multiple assignees now.
vladionescu commented 4 years ago

Hi, terribly sorry I didn't see this PR (I wonder where my GitHub notifications are going...)!

This looks very helpful, thank you for taking the time to write this up and send the PR. I am in the middle of changing where this bot runs on our infrastructure so I can't test your changes right now. Because of that I'll hold off on merging.

Overall the code looks good, I'll leave some questions/comments inline.

vladionescu commented 4 years ago

Apologies for closing this -- I didn't mean to, I was fiddling with something and didn't expect it to break PRs. I'd welcome this if it was resubmitted. I can't reopen this because of the forced push.