vladionescu / keybase-gitea-bot

Based on Keybase's Gitlab bot. Notifications in Keybase Teams for Gitea, using webhooks.
MIT License
3 stars 3 forks source link

Users without a display name configured in Gitea don't show up in notifications #4

Closed vladionescu closed 3 years ago

vladionescu commented 3 years ago

If someone doesn't have a display name/full name configured in their Gitea profile then messages from this bot don't include any notion of who performed the action being notified about. For example:

commented on issue "webhook test issue" (#5) on vlad/test-repo:

With a full name configured the above becomes

Vlad Ionescu commented on issue "webhook test issue" (#5) on vlad/test-repo:

Ideally the bot will do something like fullname || username, as a sensible default for people who haven't set their display name yet.

https://github.com/vladionescu/keybase-gitea-bot/blob/master/giteabot/http.go#L68