Great library, a few ideas

aasaru commented 3 years ago

Hi!

Great work!

A few ideas for improvement.

have as few dependencies as possible (get rid of Lombok - I'm maintaining a library that does not have Lombok and if I would add a dependency on your library it would mean my library has to depend on Lombok)
also consider adding support other countries like Lithuania (they have same id-code system as Estonia) and Latvia (beware that newer Latvian id-codes don't have birthdate in them)
make separate classes for parsing idCode, generating idCode and validating idCode - just for clarity and to separate use cases.

Cheers! Juhan

vladislavgoltjajev commented 3 years ago

Hi, thank you very much for the feedback. Haven't touched this in a while, didn't even know Bintray was dead. Might pick it up again in the future, but probably under a different name if I were to include other countries.

vladislavgoltjajev commented 3 years ago

Made a new library - https://github.com/vladislavgoltjajev/java-personal-code. Will delete this repo soon.

vladislavgoltjajev / java-isikukood

Great library, a few ideas #1