Get filename and new HTML for videos from any URI

vladkorotnev / traktor-obs-relay

Small Traktor widget template/engine for OBS in Rust and HTML/JS

MIT License

27 stars 3 forks source link

Get filename and new HTML for videos from any URI #9

Closed jota2rz closed 11 months ago

jota2rz commented 11 months ago

Updated dependencies.
Created a new API endpoint called '/filename/' to obtain song filename without extension.
New HTML 'auto-vj-uri.html' to load videos based of current song filename from any URI with faster load times.

vladkorotnev commented 11 months ago

Overall looks good enough but a few comments before it's mergeable. Especially for the update side of things, since e.g. in my setup it sits on an isolated studio machine with no connectivity, so a sudden change of deps when doing cargo run right before the show could do a fucksy wucksy :P

Feel free to drop your usecases in the wiki as well!

jota2rz commented 11 months ago

Feel free to drop your usecases in the wiki as well!

I will drop my usecase as soon as this is used live for the first time 😉

vladkorotnev commented 11 months ago

@jota2rz OK, let me know if you want to edit the Readme and add a contributors section, and then we can merge I think

jota2rz commented 11 months ago

@jota2rz OK, let me know if you want to edit the Readme and add a contributors section, and then we can merge I think

@vladkorotnev Looks good to me for a merge, as I mentioned in my other comment I'll leave it to you to handle the contributors section.