vladmandic / automatic

SD.Next: Advanced Implementation of Stable Diffusion and other Diffusion-based generative image models
https://github.com/vladmandic/automatic
GNU Affero General Public License v3.0
5.51k stars 401 forks source link

[Feature]: Extensions UI /UX and Minor bugs #1492

Open brunogcar opened 1 year ago

brunogcar commented 1 year ago

Feature description


Features


ever since you revamped Extensions tab, it is easy to see improvements over A1111 , but i feel there still room to get better cos to me its convoluted, hard to visualize and not really user friendly, so I propose:

1 - subs tabs or Type Dropdown

1.1 - Sub tabs

add subtabs System - User - Install under Manage Extensions
even though there is a column to display that info, having those shown separately makes easier to visualize and manage

tabs

1.2 - Type Dropdown

alternatively, instead of sub tabs under Manage Extensions add a dropdown with options All - System - User - Install

bar-type

2 - Additional Dropdown

to make easier to sort, by different multiple criteria, add extra one to sort by State All - Enabled - Disabled

bar

3 - Update Extensions button

Currently button - Update Installed Extensions = updates enabled extensions

to actually update all installed extensions, one would need to enable all then update so i see 2 possible and viable options

  1. slitting into 2 buttons, Update Enabled Extensions and Update Installed Extensions
  2. use dropdown boxes suggested above and update those selected that way users can specify whats shown on body page and just update that default to dropdowns all - enabled would work the same as it does now for exemple

either way with Update Installed Extensions is misleading as it just updates enabled extensions

Version Platform Description

Python 3.10.6 on Windows Version: b80fcca9 Thu Jun 22 13:05:26 2023 -0400 nVidia CUDA toolkit detected Torch 2.0.1+cu118 Torch backend: nVidia CUDA 11.8 cuDNN 8700 Torch detected GPU: NVIDIA GeForce RTX 3060 VRAM 12288 Arch (8, 6) Cores 28

brunogcar commented 1 year ago

Bugs


minor bugs with extensions that as im doing a review of the system, im going to hijack this post and report them as well

  1. Update Installed Extensions with all extensions enabled

15:46:39-320768 INFO Extensions update check: update=32 disabled=2

most probably cos i have managed extensions directly from folder with explorer or cmd, installing and deleting extensions, but app counts some disabled extensions that for sure aren't there, i dont remember when it first happened or how to reproduce

at startup it shows all installed extensions, i dont see a ghost leftover there

16:33:18-545889 INFO     Extensions enabled: ['a1111-sd-webui-lycoris', 'clip-interrogator-ext', 'LDSR', 'Lora',
                         'multidiffusion-upscaler-for-automatic1111', 'ScuNET', 'sd-dynamic-thresholding',
                         'sd-extension-system-info', 'sd-webui-agent-scheduler', 'sd-webui-controlnet',
                         'stable-diffusion-webui-images-browser', 'stable-diffusion-webui-rembg', 'SwinIR',
                         'a1111-mini-paint', 'a1111-sd-webui-haku-img', 'a1111-sd-webui-tagcomplete', 'adetailer',
                         'animator_extension', 'deforum-for-automatic1111-webui', 'infinite-zoom-automatic1111-webui',
                         'openOutpaint-webUI-extension', 'SD-CN-Animation', 'sd-extension-steps-animation',
                         'SD-latent-mirroring', 'sd-webui-ar', 'sd-webui-better-styles', 'sd-webui-cutoff',
                         'sd-webui-openpose-editor', 'sd-webui-prompt-all-in-one', 'seed_travel', 'shift-attention',
                         'stable-diffusion-webui-daam', 'stable-diffusion-webui-depthmap-script',
                         'stable-diffusion-webui-model-toolkit', 'stable-diffusion-webui-sonar', 'StylePile']
  1. Disabled extensions shows Disabled extensions-builtin on startup
09:25:33-087250 INFO     Disabled extensions-builtin: ['sd-webui-prompt-all-in-one',
                         'infinite-zoom-automatic1111-webui', 'sd-extension-steps-animation', 'animator_extension',
                         'openOutpaint-webUI-extension', 'stable-diffusion-webui-depthmap-script',
                         'a1111-sd-webui-haku-img', 'a1111-mini-paint', 'SD-CN-Animation']
09:25:33-090253 INFO     Enabled extensions-builtin: ['a1111-sd-webui-lycoris', 'clip-interrogator-ext', 'LDSR', 'Lora',                         'multidiffusion-upscaler-for-automatic1111', 'ScuNET', 'sd-dynamic-thresholding',
                         'sd-extension-system-info', 'sd-webui-agent-scheduler', 'sd-webui-controlnet',
                         'stable-diffusion-webui-images-browser', 'stable-diffusion-webui-rembg', 'SwinIR']
09:25:33-095118 INFO     Disabled extensions: ['sd-webui-prompt-all-in-one', 'infinite-zoom-automatic1111-webui',
                         'sd-extension-steps-animation', 'animator_extension', 'openOutpaint-webUI-extension',
                         'stable-diffusion-webui-depthmap-script', 'a1111-sd-webui-haku-img', 'a1111-mini-paint',
                         'SD-CN-Animation']
09:25:33-096119 INFO     Enabled extensions: ['a1111-sd-webui-tagcomplete', 'adetailer',
                         'deforum-for-automatic1111-webui', 'SD-latent-mirroring', 'sd-webui-ar',
                         'sd-webui-better-styles', 'sd-webui-cutoff', 'sd-webui-openpose-editor', 'seed_travel',
                         'shift-attention', 'stable-diffusion-webui-daam', 'stable-diffusion-webui-model-toolkit',
                         'stable-diffusion-webui-sonar', 'StylePile']

not sure if it is related with 1

  1. incorrect Avaiable Updates

sometimes some extensions displays available updates incorrectly

Update

15:56:24-453547 INFO Extensions no update available: sd-webui-better-styles c1050a3b 2023-05-12 21:58:53

Refresh extension list doesn't solve this, i used to think it was related to branches, but no idea, same as those sometimes show up as avaiable update, they disapear

thats the only one i have atm

  1. Cant Disable Deforum

once deforum is installed, it cant be disabled, can it be related to controlnet?

vladmandic commented 1 year ago

pretty much all valid suggestions, i'll put it in my backlog, currently working on some new features. regarding issues, no.2 is weird, definitely should not happen. no.3 is just "github magic" - i can pull info when extension repo was updated, but i don't know if that is in the main branch or not, so it may show up as a ghost update available. re.4 is also weird and i need to take a look. should not be related to controlnet, but i have an idea - deforum is buggy that it reports its name differently in different places, so most likely its an incorrect string match.

brunogcar commented 1 year ago

sure, take your time, those are just suggestions I think would improve upon what you have done already , as I cant code in python all i can do is suggest, test and try to reply here on other topics even with my limited knowledge

talking about suggestions i have a new one ;)

4 - display extension's README.md

ofc it easy to just click on extension link and open new page, but as README.md is already on each folder, to describe each project,

next to extension name or with its own column, have an icon [i] that would pop up Info with README.md,

would make easy to know or remember what that extension is about, choosing what to install or enable / disable, that is something minor, not really needed, but nice to have, so why not


anyway thanks for what you´ve been doing, great job