vladmandic / automatic

SD.Next: Advanced Implementation of Stable Diffusion and other Diffusion-based generative image models
https://github.com/vladmandic/automatic
GNU Affero General Public License v3.0
5.52k stars 402 forks source link

[Feature]: SD Forge Attention Couple better alternative to regional prompter with gui #3122

Open Bercraft opened 4 months ago

Bercraft commented 4 months ago

Feature description

This is an Extension for the which allows you to target conditioning at different regions. No more color bleeds or mixed features!

link to extension : https://github.com/Haoming02/sd-forge-couple#advanced-mapping

Version Platform Description

No response

Aptronymist commented 4 months ago

Feature description

This is an Extension for the which allows you to target conditioning at different regions. No more color bleeds or mixed features!

link to extension : https://github.com/Haoming02/sd-forge-couple#advanced-mapping

Sadly this is specifically created for Forge, so I seriously doubt we could use it entirely, but perhaps the UI part of it? I'll leave that for vlad to check out, if so that would be an improvement over the basic version we have by far, which I agree does need a UI of some sort.

Bercraft commented 4 months ago

I opened an issue to the creator git, he said its a backend compatibility issue. Yes i think with just the ui the reginal prompter would be really usefull and capable. Thank you for your efforts.

Aptronymist commented 4 months ago

I opened an issue to the creator git, he said its a backend compatibility issue. Yes i think with just the ui the reginal prompter would be really usefull and capable. Thank you for your efforts.

Oh yes, many many things won't work with us because they're looking for a1111 specific code/features that we do with diffusers or vlad has rewritten, especially things that involve latent manipulations. But that doesn't mean we can't take some bits here and there or inspiration for doing it better ourselves.

Bercraft commented 4 months ago

Yes i have fully understood, what now i close the request or left it open as reminder?

vladmandic commented 4 months ago

leave it open

Bercraft commented 4 months ago

I do not want to trash this request, but using the latest dev in particular the mixture tiling script, it does an awesome job but the lack of a gui is sometimes frustrating.

I also read the git hub and th gui for it is basically the regional prompter part of this extension multidiffusion-upscaler-for-automatic1111, as said on the git

"If you prefer a more user friendly graphical interface to use this algorithm, I recommend trying the Tiled Diffusion & VAE plugin developed by pkuliyi2015 for AUTOMATIC1111's stable-diffusion-webui."

thank you for your work.

lbeltrame commented 4 months ago

The major difference in the extension linked compared to what's in SD.Next currently is support for SDXL.

Bercraft commented 4 months ago

The major difference in the extension linked compared to what's in SD.Next currently is support for SDXL.

Sorry i do not want to contraddict, but the difference in not only what you mentioned, This request was opened to get a gui for all the great script that are already included with sdnext. The extension was linked just because in sdnext was added a feature called "mixture tiling" and its based on this repo "https://github.com/albarji/mixture-of-diffusers" and the author adviced that a gui is already present inside this "regional prompter part of this extension multidiffusion-upscaler-for-automatic1111, as said on the git". i did not change the request name just because i am waiting for vlad or others to ask it etc. just because i do not want to cause trouble.

lbeltrame commented 4 months ago

Oh, no problem at all. I'm aware you mentioned the GUI, but I also wanted to point out that even at the basic, non GUI functionality there's a difference (and as far as I remember, even mixture tiling in SD.Next is SD 1.5 only).

Bercraft commented 1 week ago

Any news on something for XL?