vladmandic / automatic

SD.Next: Advanced Implementation Generative Image Models
https://github.com/vladmandic/automatic
GNU Affero General Public License v3.0
5.78k stars 434 forks source link

[Issue]: Live Preview enabled significantly slows generation #3605

Open brknsoul opened 4 days ago

brknsoul commented 4 days ago

Issue Description

I believe this is due to Live Preview slowing things down.

I'll attached the gifs I took;

Live preview display period = 1, method == approximate chrome_Tyx3p6RXio

Live preview display period = 0 (ie: disabled); chrome_fm3XBE8ce5

The slowdowns seems to coincide with spikes in vram usage (first spike = generation, second spike = detailer); image

Version Platform Description

Python: version=3.10.11 platform=Windows bin="E:\sddev\venv\Scripts\python.exe"
venv="E:\sddev\venv"
Version: app=sd.next updated=2024-11-28 hash=75dd6219 branch=dev
url=https://github.com/vladmandic/automatic/tree/dev ui=dev
Repository latest available 6846f4e5d3e650d2a8dc8460906901086a350d27 2024-11-22T18:01:15Z
Platform: arch=AMD64 cpu=Intel64 Family 6 Model 151 Stepping 5, GenuineIntel system=Windows
release=Windows-10-10.0.19045-SP0 python=3.10.11 docker=False
Packages: venv=venv site=['venv', 'venv\\lib\\site-packages']
Args: ['--autolaunch', '--debug', '--uv']

Relevant log output

Command Prompt - astart.bat.txt

Backend

Diffusers

UI

Standard

Branch

Dev

Model

StableDiffusion 1.5

Acknowledgements

vladmandic commented 3 days ago

i understand the issue, but are you saying this is NEW behavior and there was no slowdown previously?

brknsoul commented 2 days ago

Just installed master, no slow down. Also, no GPU vram spikes, either.

chrome_Ocu8HPftsz

vladmandic commented 1 day ago

argh. one of those that i cannot reproduce, likely because there are no slowdowns on high end gpus.

@brknsoul as a test, can you do one thing - in modules/sd_samplers_common.py, delete line:

with queue_lock:
brknsoul commented 1 day ago

My GPU is now a 4060Ti 16gb... But I'll try. No change.