search

vladmandic / face-api

FaceAPI: AI-powered Face Detection & Rotation Tracking, Face Description & Recognition, Age & Gender & Emotion Prediction for Browser and NodeJS using TensorFlow/JS
https://vladmandic.github.io/face-api/demo/webcam.html
MIT License
850 stars 151 forks source link

feat: enable noImplicitAny #186

Closed khwalkowicz closed 9 months ago

khwalkowicz commented 9 months ago

As the name suggests, this pull request enables the "noImplicitAny" rule in the tsconfig and adds all typings missing to make this possible. This enables the end users to use "noImplicitAny" (or not) in their own repositories. Right now the end user was required to set "noImplicitAny" to "false" in his repository due to this library not being compatible (which is my case - thus the contribution), which by many is considered a bug.

vladmandic commented 9 months ago

this is a massive pr - thank you for that. i'll try to review and merge this week.

khwalkowicz commented 9 months ago

It's not that big really, the amount of lines is just package-lock.json (I believe I might have a newer version of npm and it restructured the file?). Anyways, the real amount of changes to review is very manageable 😅 Cheers!

khwalkowicz commented 9 months ago

Thank you @vladmandic !