vladmarica / better-ping-display-fabric

A Fabric mod for improving ping display in Minecraft
https://curseforge.com/minecraft/mc-mods/better-ping-display-fabric
MIT License
57 stars 15 forks source link

Conflicting with WATUT #36

Open SettingDust opened 10 months ago

SettingDust commented 10 months ago

https://modrinth.com/mod/what-are-they-up-to

https://github.com/Corosauce/WATUT/issues/8

[13:28:39] [Render thread/WARN] (FabricLoader/Mixin) @Redirect conflict. Skipping betterpingdisplay.mixins.json:PlayerListHudMixin from mod betterpingdisplay->@Redirect::redirectRenderLatencyIconCall(Lnet/minecraft/class_355;Lnet/minecraft/class_332;IIILnet/minecraft/class_640;)V with priority 1000, already redirected by watut_fabric.mixins.json:client.RenderPingIconInject from mod watut->@Redirect::renderPingIcon(Lnet/minecraft/class_355;Lnet/minecraft/class_332;IIILnet/minecraft/class_640;)V with priority 1000

java.lang.RuntimeException: Mixin transformation of net.minecraft.client.gui.hud.PlayerListHud failed
    at app//net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427)
    at app//net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
    at app//net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
    at app//net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119)
    at java.base@17.0.8/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
    at MC//net.minecraft.client.gui.hud.InGameHud.<init>(InGameHud.java:144)
    at MC//net.minecraft.client.MinecraftClient.<init>(MinecraftClient.java:603)
    at net.minecraft.client.main.Main.main(Main.java:211)
    at app//net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
    at app//net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
    at app//net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
    at app//org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87)
    at app//org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
    at app//org.prismlauncher.EntryPoint.main(EntryPoint.java:70)
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
    at app//org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392)
    at app//org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
    at app//org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
    at app//net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422)
    ... 13 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector redirectRenderLatencyIconCall(Lnet/minecraft/client/gui/hud/PlayerListHud;Lnet/minecraft/client/gui/DrawContext;IIILnet/minecraft/client/network/PlayerListEntry;)V in betterpingdisplay.mixins.json:PlayerListHudMixin from mod betterpingdisplay failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap BetterPingDisplay-Fabric-refmap.json
    at app//org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468)
    at app//org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1384)
    at app//org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1062)
    at app//org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:402)
    at app//org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:327)
    at app//org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
    at app//org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
    at app//org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
    ... 16 more
thcprophet commented 2 months ago

Same issue found with the same mods on Minecraft 1.20.1 Quilt 0.26.0 with BetterPingDisplay 1.1.1 and WATUT 1.1.3 I managed to fix it chaning one string to false in WATUT's client config: showIdleStatesInPlayerList = false