search

vladmihalcea / high-performance-java-persistence

The High-Performance Java Persistence book and video course code examples
Apache License 2.0
1.31k stars 489 forks source link

Comment out the jOOQ modules requiring a commercial license #10

Closed ursjoss closed 7 years ago

ursjoss commented 7 years ago

Vlad

It takes some setup to get the project to compile. With the jOOQ modules now in place, the databases have to be up and running.

I personally find it is feasible to request users to have the open-source databases set-up and running. However the oracle and mssql jooq modules require both the oracle/ms databses but also the commercial jOOQ versions.

I suggest to apply an opt-in approach and keep the two modules jooq-oracle and jooq-mssql inactive in the repo. Anyone wanting to activate those modules can easily do.

Cheers Urs

vladmihalcea commented 7 years ago

I forgot to remove the jOOQ module by default. I only activate it when I want to test something on jOOQ, but since it would require all DBs to be available during build, it's better to don't include it during training.

Therefore, I disabled them with this commit.