vladmihalcea / high-performance-java-persistence

The High-Performance Java Persistence book and video course code examples
Apache License 2.0
1.31k stars 489 forks source link

Oracle schema or MSSQL Schema? #20

Closed lukaseder closed 6 years ago

lukaseder commented 6 years ago

There's a file in your repository that references both the Oracle and MS SQL dialects: https://github.com/vladmihalcea/high-performance-java-persistence/blob/master/jooq/jooq-mssql/src/test/resources/oracle/initial_schema.sql

From the contents, I suspect it is MS SQL, as Oracle doesn't have BIGINT or DATETIME2 types... This looks more like Oracle syntax: https://github.com/vladmihalcea/high-performance-java-persistence/blob/master/jooq/jooq-oracle/src/test/resources/oracle/initial_schema.sql

vladmihalcea commented 6 years ago

It's in the joos-mssql module so everything is related to SQL Server.

All the initial scripts were generated by Hibernate from JPA entities.

lukaseder commented 6 years ago

Well, I was confused by the fact that there's the "oracle" directory in the path: https://github.com/vladmihalcea/high-performance-java-persistence/tree/master/jooq/jooq-mssql/src/test/resources/oracle

vladmihalcea commented 6 years ago

That's a mistake indeed.

vladmihalcea commented 6 years ago

Fixed by this commit.