GitHub enhacements - Githubissues

vladmihalcea / hypersistence-utils

The Hypersistence Utils library (previously known as Hibernate Types) gives you Spring and Hibernate utilities that can help you get the most out of your data access layer.

Apache License 2.0

2.37k stars 366 forks source link

GitHub enhacements #475

Open piotrooo opened 2 years ago

piotrooo commented 2 years ago

@vladmihalcea what do you think about couple GitHub enhancements like:

Add GitHub Action for run tests for each pull request. That let contributors feedback is everything OK with theirs changes.
Add GitHub Action for generating more readable change log, and try to use a Releases. I mean use for example release-drafter. That could be connected with using labels for PR's.
Add some tool to generate code coverage (JaCoCo and codecov)

vladmihalcea commented 2 years ago

I'm now working on adding support for Test Containers that will make tests run by GitHub Actions.

As for the release-drafter, that will not work properly since there are commits done without a Pull Request.

JaCoCo is also nice to have, but not a priority at the moment.

piotrooo commented 2 years ago

Using Pull Request can give a lot of feedback and could be treated as an additional documentation. There is any particular reason for that the commits are done without it? Maybe that could be reconsidered.

vladmihalcea commented 2 years ago

Around 90% of all the work was done by me, so issuing a PR that I review myself and rebase afterward would have been a waste of time.

PRs are fine for external committers, but even then, I don't always integrate them directly. Sometimes, I have to get their commit and rework it before I push the amended commit. GitHub will not view that as a merge since I'm rebasing an amended commit.

The current changelog is sufficient as this is a very small project that doesn't get a lot of changes.