search

vladopajic / go-test-coverage

go-test-coverage is tool and github action which reports issues when test coverage is below set threshold
GNU General Public License v3.0
78 stars 9 forks source link

update Dockerfile go version to 1.21 #50

Closed warrenguy closed 8 months ago

warrenguy commented 8 months ago

projects using go >= 1.21 may specify a go version in the format 1.23.4 in the go.mod, leading to errors parsing go.mod when using earlier versions of go

vladopajic commented 8 months ago

hello @warrenguy, thank you for contributing!

i am curios to know how did you noticed this discrepancy? did you had any issues with the tool?

thank you for bringing my attention to using go version with patch number. so far it was my understanding that patch number will be mostly irrelevant, but i'll educate myself on this matter.

warrenguy commented 8 months ago

hello @warrenguy, thank you for contributing!

you're welcome

i am curios to know how did you noticed this discrepancy? did you had any issues with the tool?

following error occured when it is built with version <1.21

failed to generate coverage statistics: could not find file [github.com/***/***/***.go]: can't find "***.go": go/build: go list github.com/***/***/***/***/: exit status 1
go: errors parsing go.mod:
/github/workspace/go.mod:3: invalid go version '1.21.4': must match format 1.23