search

vladris / tinkerer

Python blogging engine
https://vladris.com/tinkerer
Other
305 stars 81 forks source link

Add option for incremental build #100

Open rgaiacs opened 8 years ago

rgaiacs commented 8 years ago

Close #90.

rgaiacs commented 8 years ago

@vladris Do you have interest on this?

vladris commented 8 years ago

Thanks for the PR!

If I remember correctly, the reason I didn't initially support incremental build was that a bunch of stuff gets generated after all posts have been processed - things like content and metadata on the home page, the Archive, the RSS feed etc. Did you make sure all of these get properly updated with --incremental flag? When I initially implemented this I couldn't figure out a good way of updating all the required information with an incremental build.

rgaiacs commented 8 years ago

If I remember correctly, the reason I didn't initially support incremental build was that a bunch of stuff gets generated after all posts have been processed - things like content and metadata on the home page, the Archive, the RSS feed etc. Did you make sure all of these get properly updated with --incremental flag? When I initially implemented this I couldn't figure out a good way of updating all the required information with an incremental build.

I didn't check. But I need the incremental build for check my post otherwise takes a couple of minutes to rebuild since I have many photos on my blog and all the images will need to be copied again.

vladris commented 8 years ago

That makes sense actually. I would call it "partial" though instead of "incremental" to make it clear that we probably want a full build before publishing. Maybe also print a message after the build to make this clear. If you update the PR with this and make sure Travis build succeeds, I'll merge it. Thanks again for your interest in Tinkerer!

rgaiacs commented 8 years ago

If you update the PR with this and make sure Travis build succeeds, I'll merge it.

Thanks. :-) I will work on that in the next two weeks.