vladris / tinkerer

Python blogging engine
https://vladris.com/tinkerer
Other
305 stars 81 forks source link

Build error with Sphinx-1.8.1 #112

Open scudette opened 6 years ago

scudette commented 6 years ago

This currently fails with

$ tinker --build
Running Sphinx v1.8.1

Extension error:
Config value 'author' already present

The problem goes away by remove the line

app.add_config_value("author", "Winston Smith", True)

in https://github.com/vladris/tinkerer/blob/master/tinkerer/ext/blog.py#L126

The problem of course is that pip install tinkerer is currently broken because it does not pin the version of Sphinx to its tested version.

mitya57 commented 5 years ago

The reason for this is that author is now a built-in configuration variable in Sphinx. See sphinx-doc/sphinx#4518.

I would suggest renaming tinkerer's author variable to another name, or re-using the variable provided by Sphinx.

simonm3 commented 5 years ago

This is not fixed.