search

vladris / tinkerer

Python blogging engine
https://vladris.com/tinkerer
Other
305 stars 81 forks source link

Permit choice of dash to separate words in page and post names. #26

Closed sgillies closed 11 years ago

sgillies commented 11 years ago

A word_sep keyword argument is added to several functions and is ultimately used in utils.name_from_title(). I also ensure that only one instance of the word sep char appears between words and that there are no leading or trailing non-word chars in the name. I'd like to propose the same for other page/post/draft creation options.

I just found Tinkerer yesterday and it seems to be exactly what I've been looking for in a blogging tool!

vladris commented 11 years ago

Looks like Travis build failed. Are you sure all unit tests are passing with your change?

sgillies commented 11 years ago

Oops, I forgot that I had an unpushed commit (15ab605). Tests pass:

(tinker)Seans-MacBook-Air:tinkerer seang$ nosetests tinkertest/

.................................

Ran 33 tests in 2.635s

OK

vladris commented 11 years ago

Thanks for fixing!

sgillies commented 11 years ago

Fantastic! Perhaps down the road we could explore a single char option for --word-sep-dash after a survey of what other programs use. Command line option harmony is nice :)

vladris commented 11 years ago

Command line options are great but I'm pretty sure people won't want different slugs for different posts. So if somebody wants a "-" as separator, they'd have to always pass the extra command line argument. Having it in Conf.py allows you to set it during initial setup and forget about it, which in this case should be the right thing.