search

vladris / tinkerer

Python blogging engine
https://vladris.com/tinkerer
Other
305 stars 81 forks source link

navrole is a typo of nav role? #55

Closed xsharing closed 10 years ago

xsharing commented 10 years ago

in ver 1.4.1, <navrole="navigation" > appears. I think <nav role="navigation"> is correct. (added space)

xsharing commented 10 years ago

html_theme = "dark"

xsharing commented 10 years ago

I took a look at the code and there seemed to be no problem. It's weired why the space is removed. (I'm not precise with python and this template system. I don't think i can fix this, sorry.)

However, flipping the order of if clause and role="navigation" fixed this problem.

nano /usr/local/lib/python2.7/site-packages/tinkerer/themes/dark/layout.html <nav role="navigation" {%- if pages|count > 2 %} class="big_nav"{%- endif -%}>

vladris commented 10 years ago

I don't understand what the problem is. Could you please provide more details? Where do you see "navrole" (page, tag), why would you expect something else etc. I also don't understand what if clause you are flipping...

xsharing commented 10 years ago

sorry for late answering. I edited my comments which were completely weird because of stripped < and >.

i flipped the if clause inside themes/dark/layout.html

vladris commented 10 years ago

Thanks for explaining. My commit above hopefully fixes the issue. The template was using "{%-" and "-%}" where the minus sign makes Jinja2 eat up whitespace while rendering.