search

vladris / tinkerer

Python blogging engine
https://vladris.com/tinkerer
Other
305 stars 81 forks source link

Add basic Twitter support extension. #65

Closed zeth closed 10 years ago

zeth commented 10 years ago

I don't know how to do this without adding lines to layout.html, if you don't like that then I need some tips. Cheers.

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-2.03%) when pulling 255bc61e3bb2872d2eda86325eccde2163e02277 on zeth:master into 87a17b9cc5c661cec32c4c46cbfe302e213ca7d4 on vladris:master.

vladris commented 10 years ago

This does not belong in Tinkerer core. You can pull the extension itself to tinkerer-contrib and document the change needed to hook it up to the template. There is no need to modify layout.html - users can simply create their own layout.html that extends layout.html (or better yet page.html) and implement the post_meta_extra macro. It's right below the line you added to layout.html and it exists exactly for this purpose :)

For a contrib extension that does something similar, take a look here: https://github.com/vladris/tinkerer-contrib/blob/master/fbcomments/fbcomments.rst

vladris commented 10 years ago

Also please take a look at Travis log - your extension doesn't work with Python 2, only with Python 3. You might want to fix that.